chore: responsive layout modification of cards sections #3212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freefaller69
requested review from
EisenbergEffect,
radium-v,
marjonlynch,
eljefe223,
khamudom and
SamanthaAO
freefaller69
requested review from
chrisdholt,
janechu and
nicholasrice
as code owners
nicholasrice
approved these changes
Jun 2, 2020
radium-v
requested changes
Jun 2, 2020
...bsite/src/app/components/content-placement-container/content-placement-container.template.ts
Outdated
Show resolved
Hide resolved
sites/fast-website/src/app/components/content-placement/content-placement.styles.ts
Outdated
Show resolved
Hide resolved
SamanthaAO
reviewed
Jun 2, 2020
...website/src/app/components/content-placement-container/content-placement-container.styles.ts
Show resolved
Hide resolved
|
I am noticing that feature is still overflowing from its row in the wrapper starting around 1330px screen width. |
|
The comment above has been discussed and will be addressed in an upcoming PR, so that the other styling reformat changes can go in. |
SamanthaAO
approved these changes
Jun 3, 2020
freefaller69
force-pushed
the
users/v-mbenso/responsive-cards
branch
from
bd0fdce to
fbccd22
Compare
freefaller69
force-pushed
the
users/v-mbenso/responsive-cards
branch
from
6fee71c to
a59c475
Compare
eljefe223
approved these changes
Jun 4, 2020
radium-v
approved these changes
Jun 4, 2020
chrisdholt
pushed a commit
that referenced
this pull request
Jun 4, 2020
* framework section inner border and responsiveness * refactor community card section responsiveness * remove stray tag, condense styling * fix feature section hover behavior * Adjust grid properties on feature-cards Co-authored-by: Michael Benson <[email protected]>
chrisdholt
pushed a commit
that referenced
this pull request
Jun 11, 2020
* framework section inner border and responsiveness * refactor community card section responsiveness * remove stray tag, condense styling * fix feature section hover behavior * Adjust grid properties on feature-cards Co-authored-by: Michael Benson <[email protected]>
chrisdholt
pushed a commit
that referenced
this pull request
Jun 16, 2020
* framework section inner border and responsiveness * refactor community card section responsiveness * remove stray tag, condense styling * fix feature section hover behavior * Adjust grid properties on feature-cards Co-authored-by: Michael Benson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rework responsive behavior in cards sections for frameworks, features, and community.
Refactor inner border implementation in frameworks section.
Remove media queries that are no longer needed.
Motivation & context
Issue type checklist
Is this a breaking change?
Process & policy checklist