fix: update anchor styles and add destination to links #3208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khamudom
requested review from
chrisdholt,
janechu and
nicholasrice
as code owners
radium-v
reviewed
Jun 1, 2020
khamudom
force-pushed
the
users/khamu/anchor-destination
branch
from
8cc87fa to
1a475eb
Compare
…footer. update logo
khamudom
force-pushed
the
users/khamu/anchor-destination
branch
from
1a475eb to
591ff5e
Compare
eljefe223
approved these changes
Jun 3, 2020
radium-v
approved these changes
Jun 3, 2020
nicholasrice
approved these changes
Jun 3, 2020
chrisdholt
pushed a commit
that referenced
this pull request
Jun 4, 2020
* add destination to footer links * add url to links. update font color and sizes to links in header and footer. update logo * fix wrong class after a merge * align logo with label and update logo size * update hash link on logo anchor. changed div to footer * add left-right padding to footer for mobile
chrisdholt
pushed a commit
that referenced
this pull request
Jun 11, 2020
* add destination to footer links * add url to links. update font color and sizes to links in header and footer. update logo * fix wrong class after a merge * align logo with label and update logo size * update hash link on logo anchor. changed div to footer * add left-right padding to footer for mobile
chrisdholt
pushed a commit
that referenced
this pull request
Jun 16, 2020
* add destination to footer links * add url to links. update font color and sizes to links in header and footer. update logo * fix wrong class after a merge * align logo with label and update logo size * update hash link on logo anchor. changed div to footer * add left-right padding to footer for mobile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change has a destination page for the links, that are available. The styles on the links, on both full-page, in the header and footer, and inside the nav flyout, are updated, overriding the accent color and size. Updated the logo without the 'FAST' label as part of the icon.
Motivation & context
Issue type checklist
Is this a breaking change?
Process & policy checklist