Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change section header font size for mobile #3201

Merged
merged 1 commit into from
May 29, 2020
Merged

fix: change section header font size for mobile #3201

merged 1 commit into from
May 29, 2020

Conversation

khamudom
Copy link
Contributor

Description

Changed the font-size of the section header to 34px.

header-fontsize-before-after

Motivation & context

Issue type checklist

  • Chore: A change that does not impact distributed packages.
  • Bug fix: A change that fixes an issue, link to the issue above.
  • New feature: A change that adds functionality.

Is this a breaking change?

  • This change causes current functionality to break.

Process & policy checklist

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

@khamudom khamudom requested review from radium-v and eljefe223 May 29, 2020 02:26
@khamudom khamudom self-assigned this May 29, 2020
@khamudom khamudom merged commit 7200108 into feature/fast-frame May 29, 2020
@khamudom khamudom deleted the users/khamu/mobile-fontsize-header branch May 29, 2020 19:05
chrisdholt pushed a commit that referenced this pull request Jun 4, 2020
@khamudom @chrisdholt
change section header font size for mobile (#3201)
18bf452
chrisdholt pushed a commit that referenced this pull request Jun 11, 2020
@khamudom @chrisdholt
change section header font size for mobile (#3201)
c57a0da
chrisdholt pushed a commit that referenced this pull request Jun 16, 2020
@khamudom @chrisdholt
change section header font size for mobile (#3201)
a3f1fd7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janechu janechu janechu approved these changes

@nicholasrice nicholasrice nicholasrice approved these changes

@radium-v radium-v radium-v approved these changes

@eljefe223 eljefe223 Awaiting requested review from eljefe223

@chrisdholt chrisdholt Awaiting requested review from chrisdholt

Assignees

@khamudom khamudom

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@khamudom @radium-v @nicholasrice @janechu