Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add feature card to content-placement-container and update hover styles #3177

Merged
merged 9 commits into from
May 26, 2020

Conversation

SamanthaAO
Copy link
Contributor

@SamanthaAO SamanthaAO commented May 22, 2020

Description

  • add feature cards to content-placement-container
  • create data to be used to create feature cards
  • update hover styling for both feature and community section
  • the color when a card is not hovered on is currently --neutral-foreground-hint though it would be ideal if we had a --neutral-foreground-inactive of some sort to use for the variable here, but currently hint is closest to the color in figma
  • --neutral-fill-active is used for the background of the card on hover. This is lighter than the color in the figma, but shows a contrast against the current background color so the hover background can be seen
  • add withBehaviors to styles

Screen Shot 2020-05-21 at 5 18 59 PM

Screen Shot 2020-05-21 at 5 19 06 PM

Motivation & context

Issue type checklist

  • Chore: A change that does not impact distributed packages.
  • Bug fix: A change that fixes an issue, link to the issue above.
  • New feature: A change that adds functionality.

Is this a breaking change?

  • This change causes current functionality to break.

Process & policy checklist

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

@SamanthaAO SamanthaAO force-pushed the users/v-sorcut/section-container branch from 59bcbc9 to 03130df Compare May 22, 2020 18:31
@SamanthaAO SamanthaAO requested a review from nicholasrice May 22, 2020 19:05
@SamanthaAO SamanthaAO force-pushed the users/v-sorcut/section-container branch from 4edcd79 to c69aa9d Compare May 26, 2020 16:24
@SamanthaAO SamanthaAO merged commit 41332fe into feature/fast-frame May 26, 2020
@SamanthaAO SamanthaAO deleted the users/v-sorcut/section-container branch May 26, 2020 16:52
chrisdholt pushed a commit that referenced this pull request Jun 4, 2020
…er styles (#3177)

* add svg, update padding and text variables, add borders to framework to align with design

* remove class's for framework content placement and use nth-of-type. update h3 style. update section container class naming function

* add feature-card to content-placement-container

* removed comented out text from index, make style changes needed post rebase, and remove unused imports

* add updated hover design to features and community

* switched box-shadow for elevation algorithm. removed back shadow on individual cards

* add with behaviors to styles

* update comment

* fix layout issue after rebase
chrisdholt pushed a commit that referenced this pull request Jun 11, 2020
…er styles (#3177)

* add svg, update padding and text variables, add borders to framework to align with design

* remove class's for framework content placement and use nth-of-type. update h3 style. update section container class naming function

* add feature-card to content-placement-container

* removed comented out text from index, make style changes needed post rebase, and remove unused imports

* add updated hover design to features and community

* switched box-shadow for elevation algorithm. removed back shadow on individual cards

* add with behaviors to styles

* update comment

* fix layout issue after rebase
chrisdholt pushed a commit that referenced this pull request Jun 16, 2020
…er styles (#3177)

* add svg, update padding and text variables, add borders to framework to align with design

* remove class's for framework content placement and use nth-of-type. update h3 style. update section container class naming function

* add feature-card to content-placement-container

* removed comented out text from index, make style changes needed post rebase, and remove unused imports

* add updated hover design to features and community

* switched box-shadow for elevation algorithm. removed back shadow on individual cards

* add with behaviors to styles

* update comment

* fix layout issue after rebase
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants