-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add feature card to content-placement-container and update hover styles #3177
Merged
SamanthaAO
merged 9 commits into
feature/fast-frame
from
users/v-sorcut/section-container
May 26, 2020
Merged
chore: add feature card to content-placement-container and update hover styles #3177
SamanthaAO
merged 9 commits into
feature/fast-frame
from
users/v-sorcut/section-container
May 26, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamanthaAO
requested review from
chrisdholt,
janechu and
nicholasrice
as code owners
May 22, 2020 00:59
...website/src/app/components/content-placement-container/content-placement-container.styles.ts
Outdated
Show resolved
Hide resolved
freefaller69
approved these changes
May 22, 2020
SamanthaAO
force-pushed
the
users/v-sorcut/section-container
branch
from
May 22, 2020 18:31
59bcbc9
to
03130df
Compare
…to align with design
…pdate h3 style. update section container class naming function
…rebase, and remove unused imports
SamanthaAO
force-pushed
the
users/v-sorcut/section-container
branch
from
May 26, 2020 16:24
4edcd79
to
c69aa9d
Compare
nicholasrice
approved these changes
May 26, 2020
chrisdholt
pushed a commit
that referenced
this pull request
Jun 4, 2020
…er styles (#3177) * add svg, update padding and text variables, add borders to framework to align with design * remove class's for framework content placement and use nth-of-type. update h3 style. update section container class naming function * add feature-card to content-placement-container * removed comented out text from index, make style changes needed post rebase, and remove unused imports * add updated hover design to features and community * switched box-shadow for elevation algorithm. removed back shadow on individual cards * add with behaviors to styles * update comment * fix layout issue after rebase
chrisdholt
pushed a commit
that referenced
this pull request
Jun 11, 2020
…er styles (#3177) * add svg, update padding and text variables, add borders to framework to align with design * remove class's for framework content placement and use nth-of-type. update h3 style. update section container class naming function * add feature-card to content-placement-container * removed comented out text from index, make style changes needed post rebase, and remove unused imports * add updated hover design to features and community * switched box-shadow for elevation algorithm. removed back shadow on individual cards * add with behaviors to styles * update comment * fix layout issue after rebase
chrisdholt
pushed a commit
that referenced
this pull request
Jun 16, 2020
…er styles (#3177) * add svg, update padding and text variables, add borders to framework to align with design * remove class's for framework content placement and use nth-of-type. update h3 style. update section container class naming function * add feature-card to content-placement-container * removed comented out text from index, make style changes needed post rebase, and remove unused imports * add updated hover design to features and community * switched box-shadow for elevation algorithm. removed back shadow on individual cards * add with behaviors to styles * update comment * fix layout issue after rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation & context
Issue type checklist
Is this a breaking change?
Process & policy checklist