chore: update styles for framework and community sections #3162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamanthaAO
requested review from
chrisdholt,
janechu and
nicholasrice
as code owners
radium-v
requested changes
May 19, 2020
...website/src/app/components/content-placement-container/content-placement-container.styles.ts
Show resolved
Hide resolved
...website/src/app/components/content-placement-container/content-placement-container.styles.ts
Outdated
Show resolved
Hide resolved
...bsite/src/app/components/content-placement-container/content-placement-container.template.ts
Outdated
Show resolved
Hide resolved
...website/src/app/components/content-placement-container/content-placement-container.styles.ts
Outdated
Show resolved
Hide resolved
nicholasrice
approved these changes
May 20, 2020
…to align with design
…pdate h3 style. update section container class naming function
SamanthaAO
force-pushed
the
users/v-sorcut/content-placement-style-update
branch
from
b0107a3 to
d55c7bd
Compare
eljefe223
approved these changes
May 21, 2020
radium-v
approved these changes
May 21, 2020
chrisdholt
pushed a commit
that referenced
this pull request
Jun 4, 2020
* add svg, update padding and text variables, add borders to framework to align with design * switch twitter and github icons so they are assigned correctly * remove class's for framework content placement and use nth-of-type. update h3 style. update section container class naming function * update container naming function * add border variable * update borders to be more reusable * Change grid borders to be mobile-first Co-authored-by: John Kreitlow <[email protected]>
chrisdholt
pushed a commit
that referenced
this pull request
Jun 11, 2020
* add svg, update padding and text variables, add borders to framework to align with design * switch twitter and github icons so they are assigned correctly * remove class's for framework content placement and use nth-of-type. update h3 style. update section container class naming function * update container naming function * add border variable * update borders to be more reusable * Change grid borders to be mobile-first Co-authored-by: John Kreitlow <[email protected]>
chrisdholt
pushed a commit
that referenced
this pull request
Jun 16, 2020
* add svg, update padding and text variables, add borders to framework to align with design * switch twitter and github icons so they are assigned correctly * remove class's for framework content placement and use nth-of-type. update h3 style. update section container class naming function * update container naming function * add border variable * update borders to be more reusable * Change grid borders to be mobile-first Co-authored-by: John Kreitlow <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update framework to match design update. Remove divider, compatibility slot, and action slot. Add borders that change on screen resize.
Update community with appropriate icons.
Change content-placement-container to use grid instead of flex to align with how other parts of the site are structured. Remove width of 400 for cards, so that they can be smaller when viewed on a phone. Update padding and text sizes to align with figma
Motivation & context
Issue type checklist
Is this a breaking change?
Process & policy checklist