-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: gets feature branch back to a working state #3153
Merged
eljefe223
merged 6 commits into
feature/fast-frame
from
users/jes/back-to-working-state
May 18, 2020
Merged
fix: gets feature branch back to a working state #3153
eljefe223
merged 6 commits into
feature/fast-frame
from
users/jes/back-to-working-state
May 18, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eljefe223
requested review from
EisenbergEffect,
radium-v,
nicholasrice,
chrisdholt,
khamudom and
SamanthaAO
May 16, 2020 01:08
eljefe223
force-pushed
the
users/jes/back-to-working-state
branch
from
May 16, 2020 01:39
8629ebd
to
18be153
Compare
EisenbergEffect
approved these changes
May 16, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If possible, can you revert the change to fast-components so I have less merge conflicts to resolve 😄
khamudom
approved these changes
May 16, 2020
Reverted, not sure what that was might have been prettier doing its thing. |
nicholasrice
approved these changes
May 18, 2020
SamanthaAO
approved these changes
May 18, 2020
chrisdholt
pushed a commit
that referenced
this pull request
May 18, 2020
* intial setup * more work * fremoved import * refactored repeat * updated refrences after rebase, fixed styles * revert fast component chnage
radium-v
pushed a commit
that referenced
this pull request
May 18, 2020
* intial setup * more work * fremoved import * refactored repeat * updated refrences after rebase, fixed styles * revert fast component chnage
chrisdholt
pushed a commit
that referenced
this pull request
May 18, 2020
* intial setup * more work * fremoved import * refactored repeat * updated refrences after rebase, fixed styles * revert fast component chnage
chrisdholt
pushed a commit
that referenced
this pull request
Jun 4, 2020
* intial setup * more work * fremoved import * refactored repeat * updated refrences after rebase, fixed styles * revert fast component chnage
chrisdholt
pushed a commit
that referenced
this pull request
Jun 11, 2020
* intial setup * more work * fremoved import * refactored repeat * updated refrences after rebase, fixed styles * revert fast component chnage
chrisdholt
pushed a commit
that referenced
this pull request
Jun 16, 2020
* intial setup * more work * fremoved import * refactored repeat * updated refrences after rebase, fixed styles * revert fast component chnage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since we moved around some utilities and changed around some apis we needed to do some work to get the feature branch building again.
Motivation & context
Issue type checklist
Is this a breaking change?
Process & policy checklist