Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: gets feature branch back to a working state #3153

Merged
merged 6 commits into from
May 18, 2020

Conversation

eljefe223
Copy link
Contributor

Description

Since we moved around some utilities and changed around some apis we needed to do some work to get the feature branch building again.

Motivation & context

Issue type checklist

  • Chore: A change that does not impact distributed packages.
  • Bug fix: A change that fixes an issue, link to the issue above.
  • New feature: A change that adds functionality.

Is this a breaking change?

  • This change causes current functionality to break.

Process & policy checklist

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.
###

@eljefe223 eljefe223 force-pushed the users/jes/back-to-working-state branch from 8629ebd to 18be153 Compare May 16, 2020 01:39
Copy link
Contributor

@EisenbergEffect EisenbergEffect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If possible, can you revert the change to fast-components so I have less merge conflicts to resolve 😄

@eljefe223
Copy link
Contributor Author

If possible, can you revert the change to fast-components so I have less merge conflicts to resolve 😄

Reverted, not sure what that was might have been prettier doing its thing.

@eljefe223 eljefe223 merged commit bd7cf41 into feature/fast-frame May 18, 2020
@eljefe223 eljefe223 deleted the users/jes/back-to-working-state branch May 18, 2020 16:27
chrisdholt pushed a commit that referenced this pull request May 18, 2020
* intial setup

* more work

* fremoved import

* refactored repeat

* updated refrences after rebase, fixed styles

* revert fast component chnage
radium-v pushed a commit that referenced this pull request May 18, 2020
* intial setup

* more work

* fremoved import

* refactored repeat

* updated refrences after rebase, fixed styles

* revert fast component chnage
chrisdholt pushed a commit that referenced this pull request May 18, 2020
* intial setup

* more work

* fremoved import

* refactored repeat

* updated refrences after rebase, fixed styles

* revert fast component chnage
chrisdholt pushed a commit that referenced this pull request Jun 4, 2020
* intial setup

* more work

* fremoved import

* refactored repeat

* updated refrences after rebase, fixed styles

* revert fast component chnage
chrisdholt pushed a commit that referenced this pull request Jun 11, 2020
* intial setup

* more work

* fremoved import

* refactored repeat

* updated refrences after rebase, fixed styles

* revert fast component chnage
chrisdholt pushed a commit that referenced this pull request Jun 16, 2020
* intial setup

* more work

* fremoved import

* refactored repeat

* updated refrences after rebase, fixed styles

* revert fast component chnage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants