chore: move svgs to files and use svg-inline-loader
#3146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radium-v
force-pushed
the
users/jokreitl/site-svg-loader
branch
2 times, most recently
from
994537e to
a786ab4
Compare
radium-v
requested review from
chrisdholt,
janechu and
nicholasrice
as code owners
radium-v
requested review from
eljefe223,
EisenbergEffect,
khamudom,
freefaller69 and
SamanthaAO
SamanthaAO
approved these changes
May 15, 2020
chrisdholt
force-pushed
the
feature/fast-frame
branch
from
89fd313 to
c45f37b
Compare
khamudom
approved these changes
May 18, 2020
|
@radium-v looks like you need to rebase this one - I'll take a look after you do that. |
chrisdholt
force-pushed
the
feature/fast-frame
branch
from
bd7cf41 to
6f5f8bc
Compare
radium-v
force-pushed
the
users/jokreitl/site-svg-loader
branch
from
a786ab4 to
27334a7
Compare
radium-v
force-pushed
the
users/jokreitl/site-svg-loader
branch
from
27334a7 to
4170583
Compare
freefaller69
approved these changes
May 18, 2020
eljefe223
approved these changes
May 18, 2020
nicholasrice
approved these changes
May 18, 2020
chrisdholt
pushed a commit
that referenced
this pull request
May 18, 2020
chrisdholt
pushed a commit
that referenced
this pull request
Jun 4, 2020
chrisdholt
pushed a commit
that referenced
this pull request
Jun 11, 2020
chrisdholt
pushed a commit
that referenced
this pull request
Jun 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change adds the
svg-inline-loaderand moves existing SVG markup into separate files.Motivation & context
To help make template composition cleaner, SVG files can now be loaded as TS modules and inserted as string literals directly into templates.
Issue type checklist
Is this a breaking change?
Note: run
yarn installagain to ensure the new webpack loader is present.Process & policy checklist