feat: add feature-card and card-section components #3119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
chrisdholt
force-pushed
the
feature/fast-frame
branch
from
6f3af9e to
0a2ad02
Compare
radium-v
requested review from
radium-v,
khamudom,
eljefe223,
SamanthaAO and
chrisdholt
freefaller69
force-pushed
the
users/v-mbenso/features-cards
branch
from
d3159f2 to
32ac79e
Compare
awentzel
reviewed
May 14, 2020
sites/fast-website/src/app/components/card-section/card-section.template.ts
Outdated
Show resolved
Hide resolved
awentzel
reviewed
May 14, 2020
awentzel
reviewed
May 14, 2020
chrisdholt
reviewed
May 14, 2020
sites/fast-website/src/app/components/feature-card/feature-card.styles.ts
Outdated
Show resolved
Hide resolved
awentzel
reviewed
May 14, 2020
chrisdholt
reviewed
May 14, 2020
sites/fast-website/src/app/components/feature-card/feature-card.styles.ts
Outdated
Show resolved
Hide resolved
chrisdholt
reviewed
May 14, 2020
sites/fast-website/src/app/components/feature-card/feature-card.styles.ts
Outdated
Show resolved
Hide resolved
chrisdholt
reviewed
May 14, 2020
sites/fast-website/src/app/components/feature-card/feature-card.styles.ts
Outdated
Show resolved
Hide resolved
chrisdholt
reviewed
May 14, 2020
sites/fast-website/src/app/components/feature-card/feature-card.styles.ts
Outdated
Show resolved
Hide resolved
chrisdholt
reviewed
May 14, 2020
SamanthaAO
reviewed
May 14, 2020
SamanthaAO
reviewed
May 14, 2020
SamanthaAO
reviewed
May 14, 2020
SamanthaAO
reviewed
May 14, 2020
sites/fast-website/src/app/components/card-section/card-section.styles.ts
Show resolved
Hide resolved
SamanthaAO
reviewed
May 14, 2020
sites/fast-website/src/app/components/feature-card/feature-card.styles.ts
Outdated
Show resolved
Hide resolved
SamanthaAO
reviewed
May 14, 2020
freefaller69
force-pushed
the
users/v-mbenso/features-cards
branch
from
ab15341 to
b0f80e7
Compare
radium-v
approved these changes
May 15, 2020
SamanthaAO
approved these changes
May 15, 2020
added 17 commits
May 15, 2020 16:56
freefaller69
force-pushed
the
users/v-mbenso/features-cards
branch
from
b867dd2 to
2d7f7d3
Compare
chrisdholt
reviewed
May 16, 2020
chrisdholt
reviewed
May 16, 2020
sites/fast-website/src/app/components/card-section/card-section.ts
Outdated
Show resolved
Hide resolved
chrisdholt
approved these changes
May 16, 2020
chrisdholt
pushed a commit
that referenced
this pull request
May 18, 2020
* Add feature card component * Add feature card section * Add feature card section to index.html * Update card styles * change links slot to footer * Add neutralForegroundRestBehavior to feature-card * Remove unused css custom property * Add ::before separator element to cards * feat: add accent color and background color selection (#3123) * feat: add color pickers and preview * formatting * added dark / light mode * add prettier * ran prettier * saved last index for selecting background * addressed Rob's comments * ran prettier * addressed comments * styling fixes * fix file formatting * fix import * formatting issue * formatting * fix tabs to spaces * change selector from h5 to :first-child * Append Site prefix * make feature-card responsive * remove style property * fix import and closing tags * remove fast-anchor color * refactor card elements * modify class extension Co-authored-by: Michael Benson <[email protected]> Co-authored-by: Jeff Smith <[email protected]>
radium-v
pushed a commit
that referenced
this pull request
May 18, 2020
* Add feature card component * Add feature card section * Add feature card section to index.html * Update card styles * change links slot to footer * Add neutralForegroundRestBehavior to feature-card * Remove unused css custom property * Add ::before separator element to cards * feat: add accent color and background color selection (#3123) * feat: add color pickers and preview * formatting * added dark / light mode * add prettier * ran prettier * saved last index for selecting background * addressed Rob's comments * ran prettier * addressed comments * styling fixes * fix file formatting * fix import * formatting issue * formatting * fix tabs to spaces * change selector from h5 to :first-child * Append Site prefix * make feature-card responsive * remove style property * fix import and closing tags * remove fast-anchor color * refactor card elements * modify class extension Co-authored-by: Michael Benson <[email protected]> Co-authored-by: Jeff Smith <[email protected]>
chrisdholt
pushed a commit
that referenced
this pull request
May 18, 2020
* Add feature card component * Add feature card section * Add feature card section to index.html * Update card styles * change links slot to footer * Add neutralForegroundRestBehavior to feature-card * Remove unused css custom property * Add ::before separator element to cards * feat: add accent color and background color selection (#3123) * feat: add color pickers and preview * formatting * added dark / light mode * add prettier * ran prettier * saved last index for selecting background * addressed Rob's comments * ran prettier * addressed comments * styling fixes * fix file formatting * fix import * formatting issue * formatting * fix tabs to spaces * change selector from h5 to :first-child * Append Site prefix * make feature-card responsive * remove style property * fix import and closing tags * remove fast-anchor color * refactor card elements * modify class extension Co-authored-by: Michael Benson <[email protected]> Co-authored-by: Jeff Smith <[email protected]>
chrisdholt
pushed a commit
that referenced
this pull request
Jun 4, 2020
* Add feature card component * Add feature card section * Add feature card section to index.html * Update card styles * change links slot to footer * Add neutralForegroundRestBehavior to feature-card * Remove unused css custom property * Add ::before separator element to cards * feat: add accent color and background color selection (#3123) * feat: add color pickers and preview * formatting * added dark / light mode * add prettier * ran prettier * saved last index for selecting background * addressed Rob's comments * ran prettier * addressed comments * styling fixes * fix file formatting * fix import * formatting issue * formatting * fix tabs to spaces * change selector from h5 to :first-child * Append Site prefix * make feature-card responsive * remove style property * fix import and closing tags * remove fast-anchor color * refactor card elements * modify class extension Co-authored-by: Michael Benson <[email protected]> Co-authored-by: Jeff Smith <[email protected]>
chrisdholt
pushed a commit
that referenced
this pull request
Jun 11, 2020
* Add feature card component * Add feature card section * Add feature card section to index.html * Update card styles * change links slot to footer * Add neutralForegroundRestBehavior to feature-card * Remove unused css custom property * Add ::before separator element to cards * feat: add accent color and background color selection (#3123) * feat: add color pickers and preview * formatting * added dark / light mode * add prettier * ran prettier * saved last index for selecting background * addressed Rob's comments * ran prettier * addressed comments * styling fixes * fix file formatting * fix import * formatting issue * formatting * fix tabs to spaces * change selector from h5 to :first-child * Append Site prefix * make feature-card responsive * remove style property * fix import and closing tags * remove fast-anchor color * refactor card elements * modify class extension Co-authored-by: Michael Benson <[email protected]> Co-authored-by: Jeff Smith <[email protected]>
chrisdholt
pushed a commit
that referenced
this pull request
Jun 16, 2020
* Add feature card component * Add feature card section * Add feature card section to index.html * Update card styles * change links slot to footer * Add neutralForegroundRestBehavior to feature-card * Remove unused css custom property * Add ::before separator element to cards * feat: add accent color and background color selection (#3123) * feat: add color pickers and preview * formatting * added dark / light mode * add prettier * ran prettier * saved last index for selecting background * addressed Rob's comments * ran prettier * addressed comments * styling fixes * fix file formatting * fix import * formatting issue * formatting * fix tabs to spaces * change selector from h5 to :first-child * Append Site prefix * make feature-card responsive * remove style property * fix import and closing tags * remove fast-anchor color * refactor card elements * modify class extension Co-authored-by: Michael Benson <[email protected]> Co-authored-by: Jeff Smith <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Create feature-card template component extended from fast-card with a header slot, footer slot, and default slot for content. Create card-section component for grid placement of feature-cards. Implement hover behaviors on cards and card sections to match design.
Motivation & context
Issue type checklist
Is this a breaking change?
Process & policy checklist