feat: add navigation menu component #3111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khamudom
requested review from
chrisdholt,
janechu and
nicholasrice
as code owners
EisenbergEffect
approved these changes
May 12, 2020
|
Approved but had a second thought. I think we should prefix all the components built specifically for the site with something other than |
marjonlynch
reviewed
May 12, 2020
marjonlynch
approved these changes
May 12, 2020
chrisdholt
reviewed
May 12, 2020
sites/fast-website/src/app/components/site-navigation/site-navigation.ts
Outdated
Show resolved
Hide resolved
chrisdholt
force-pushed
the
feature/fast-frame
branch
from
5c3eb72 to
8dc8c69
Compare
khamudom
force-pushed
the
users/khamu/fast-frame-site-navigation
branch
from
09aa0d4 to
1eaf9c4
Compare
eljefe223
reviewed
May 12, 2020
khamudom
force-pushed
the
users/khamu/fast-frame-site-navigation
branch
from
6b62de6 to
cde05a6
Compare
|
I think this should be a feat - not a chore :) |
khamudom
changed the title
eljefe223
approved these changes
May 13, 2020
radium-v
approved these changes
May 13, 2020
chrisdholt
reviewed
May 13, 2020
|
I think we should add |
eljefe223
requested changes
May 13, 2020
sites/fast-website/src/app/components/navigation/navigation.template.ts
Outdated
Show resolved
Hide resolved
…servable, add withBehavior to styles file
khamudom
force-pushed
the
users/khamu/fast-frame-site-navigation
branch
from
cde05a6 to
b27d226
Compare
chrisdholt
approved these changes
May 13, 2020
eljefe223
approved these changes
May 13, 2020
chrisdholt
pushed a commit
that referenced
this pull request
May 13, 2020
* create initial files for navigation component * add slotted for nav items * use the prefix site for the components, addressed rtl, removed adding role attribute * rebased. add start and end template, removed slotted directive and observable, add withBehavior to styles file
chrisdholt
pushed a commit
that referenced
this pull request
May 15, 2020
* create initial files for navigation component * add slotted for nav items * use the prefix site for the components, addressed rtl, removed adding role attribute * rebased. add start and end template, removed slotted directive and observable, add withBehavior to styles file
chrisdholt
pushed a commit
that referenced
this pull request
May 18, 2020
* create initial files for navigation component * add slotted for nav items * use the prefix site for the components, addressed rtl, removed adding role attribute * rebased. add start and end template, removed slotted directive and observable, add withBehavior to styles file
radium-v
pushed a commit
that referenced
this pull request
May 18, 2020
* create initial files for navigation component * add slotted for nav items * use the prefix site for the components, addressed rtl, removed adding role attribute * rebased. add start and end template, removed slotted directive and observable, add withBehavior to styles file
chrisdholt
pushed a commit
that referenced
this pull request
May 18, 2020
* create initial files for navigation component * add slotted for nav items * use the prefix site for the components, addressed rtl, removed adding role attribute * rebased. add start and end template, removed slotted directive and observable, add withBehavior to styles file
chrisdholt
pushed a commit
that referenced
this pull request
Jun 4, 2020
* create initial files for navigation component * add slotted for nav items * use the prefix site for the components, addressed rtl, removed adding role attribute * rebased. add start and end template, removed slotted directive and observable, add withBehavior to styles file
chrisdholt
pushed a commit
that referenced
this pull request
Jun 11, 2020
* create initial files for navigation component * add slotted for nav items * use the prefix site for the components, addressed rtl, removed adding role attribute * rebased. add start and end template, removed slotted directive and observable, add withBehavior to styles file
chrisdholt
pushed a commit
that referenced
this pull request
Jun 16, 2020
* create initial files for navigation component * add slotted for nav items * use the prefix site for the components, addressed rtl, removed adding role attribute * rebased. add start and end template, removed slotted directive and observable, add withBehavior to styles file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Created a navigation component to use for the navigation page menu. The template is a nav element with a slotted directive. Each navigation item also gets an attribute of
role="listitem"added. Implemented the control on the page in the header and footer.Motivation & context
Issue type checklist
Is this a breaking change?
Process & policy checklist