-
Notifications
You must be signed in to change notification settings - Fork 600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create content-placement component for marketing site #3105
feat: create content-placement component for marketing site #3105
Conversation
sites/fast-website/src/app/components/content-card/content-card.styles.ts
Outdated
Show resolved
Hide resolved
sites/fast-website/src/app/components/content-card/content-card.template.ts
Outdated
Show resolved
Hide resolved
Seeing what others think, but to me it's more intuitive if the default slot is the largest section of text / content. It just seems easier to manage than having the slot assigned to that large bit of text. I propose ditching the |
I tend to think in terms of what the component or design would require rather than the largest amount of content. Would we ever have body without a heading given the current design? I think it's more likely that the heading would always be there. Things like an image, action, or body/summary text may not always be required. |
I'm under the impression that they are both required, could be a rule to consider if you have multiple required attributes. |
5c3eb72
to
8dc8c69
Compare
669cf0c
to
8453bb5
Compare
sites/fast-website/src/app/components/content-placement/content-placement.ts
Outdated
Show resolved
Hide resolved
sites/fast-website/src/app/components/content-placement/content-placement.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with above changes.
This should also be a feat not a chore |
0f6a348
to
eacd1d3
Compare
…de hover-card, update main styles so that cards wrap
…ng so there is no unneeded space when slot is not used
eacd1d3
to
dd8f8a3
Compare
That is because currently the whole site uses a grid so on the left and right there is a section where the container is a bit larger than the cards because of how the grid is set up. If the overall layout is changed to flex then the container could be the same size as the cards instead of being the size of the column in the grid that it is defined as. I did not want to make a change to the overall layout at this time with this component, but it is definitely something that should be addressed. |
* add hover-card component * add components to index.html, update component index exports to include hover-card, update main styles so that cards wrap * updated style to be more layout centric * rename component and update spacing in styles * change component name to content-placement * made style updates so all cards are the same height and body stretches * replace FAST prefix with site * update divider attribute to boolean mode and remove true for divider in public index * updated styles to work woth changes in feature and changes icon styling so there is no unneeded space when slot is not used * update color for links to match figma using design system
* add hover-card component * add components to index.html, update component index exports to include hover-card, update main styles so that cards wrap * updated style to be more layout centric * rename component and update spacing in styles * change component name to content-placement * made style updates so all cards are the same height and body stretches * replace FAST prefix with site * update divider attribute to boolean mode and remove true for divider in public index * updated styles to work woth changes in feature and changes icon styling so there is no unneeded space when slot is not used * update color for links to match figma using design system
* add hover-card component * add components to index.html, update component index exports to include hover-card, update main styles so that cards wrap * updated style to be more layout centric * rename component and update spacing in styles * change component name to content-placement * made style updates so all cards are the same height and body stretches * replace FAST prefix with site * update divider attribute to boolean mode and remove true for divider in public index * updated styles to work woth changes in feature and changes icon styling so there is no unneeded space when slot is not used * update color for links to match figma using design system
* add hover-card component * add components to index.html, update component index exports to include hover-card, update main styles so that cards wrap * updated style to be more layout centric * rename component and update spacing in styles * change component name to content-placement * made style updates so all cards are the same height and body stretches * replace FAST prefix with site * update divider attribute to boolean mode and remove true for divider in public index * updated styles to work woth changes in feature and changes icon styling so there is no unneeded space when slot is not used * update color for links to match figma using design system
* add hover-card component * add components to index.html, update component index exports to include hover-card, update main styles so that cards wrap * updated style to be more layout centric * rename component and update spacing in styles * change component name to content-placement * made style updates so all cards are the same height and body stretches * replace FAST prefix with site * update divider attribute to boolean mode and remove true for divider in public index * updated styles to work woth changes in feature and changes icon styling so there is no unneeded space when slot is not used * update color for links to match figma using design system
* add hover-card component * add components to index.html, update component index exports to include hover-card, update main styles so that cards wrap * updated style to be more layout centric * rename component and update spacing in styles * change component name to content-placement * made style updates so all cards are the same height and body stretches * replace FAST prefix with site * update divider attribute to boolean mode and remove true for divider in public index * updated styles to work woth changes in feature and changes icon styling so there is no unneeded space when slot is not used * update color for links to match figma using design system
* add hover-card component * add components to index.html, update component index exports to include hover-card, update main styles so that cards wrap * updated style to be more layout centric * rename component and update spacing in styles * change component name to content-placement * made style updates so all cards are the same height and body stretches * replace FAST prefix with site * update divider attribute to boolean mode and remove true for divider in public index * updated styles to work woth changes in feature and changes icon styling so there is no unneeded space when slot is not used * update color for links to match figma using design system
* add hover-card component * add components to index.html, update component index exports to include hover-card, update main styles so that cards wrap * updated style to be more layout centric * rename component and update spacing in styles * change component name to content-placement * made style updates so all cards are the same height and body stretches * replace FAST prefix with site * update divider attribute to boolean mode and remove true for divider in public index * updated styles to work woth changes in feature and changes icon styling so there is no unneeded space when slot is not used * update color for links to match figma using design system
Description
this component is used to generate cards in the frameworks and community section.
the template consists of one default slot and 4 named slots (icon, body, action, and compatibility). the styles define the layouts of the cards and change them based on hover
Motivation & context
Issue type checklist
Is this a breaking change?
Process & policy checklist