Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create content-placement component for marketing site #3105

Merged
merged 10 commits into from
May 13, 2020

Conversation

SamanthaAO
Copy link
Contributor

@SamanthaAO SamanthaAO commented May 11, 2020

Description

this component is used to generate cards in the frameworks and community section.
Screen Shot 2020-05-11 at 10 03 21 AM
Screen Shot 2020-05-11 at 10 03 38 AM
the template consists of one default slot and 4 named slots (icon, body, action, and compatibility). the styles define the layouts of the cards and change them based on hover

Motivation & context

Issue type checklist

  • Chore: A change that does not impact distributed packages.
  • Bug fix: A change that fixes an issue, link to the issue above.
  • New feature: A change that adds functionality.

Is this a breaking change?

  • This change causes current functionality to break.

Process & policy checklist

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

@msftclas
Copy link

msftclas commented May 11, 2020

CLA assistant check
All CLA requirements met.

@eljefe223
Copy link
Contributor

Seeing what others think, but to me it's more intuitive if the default slot is the largest section of text / content. It just seems easier to manage than having the slot assigned to that large bit of text.

I propose ditching the body slot and making that the default and then adding a title slot.

@chrisdholt
Copy link
Member

Seeing what others think, but to me it's more intuitive if the default slot is the largest section of text / content. It just seems easier to manage than having the slot assigned to that large bit of text.

I propose ditching the body slot and making that the default and then adding a title slot.

I tend to think in terms of what the component or design would require rather than the largest amount of content. Would we ever have body without a heading given the current design? I think it's more likely that the heading would always be there. Things like an image, action, or body/summary text may not always be required.

@eljefe223
Copy link
Contributor

Seeing what others think, but to me it's more intuitive if the default slot is the largest section of text / content. It just seems easier to manage than having the slot assigned to that large bit of text.
I propose ditching the body slot and making that the default and then adding a title slot.

I tend to think in terms of what the component or design would require rather than the largest amount of content. Would we ever have body without a heading given the current design? I think it's more likely that the heading would always be there. Things like an image, action, or body/summary text may not always be required.

I'm under the impression that they are both required, could be a rule to consider if you have multiple required attributes.

@chrisdholt chrisdholt force-pushed the feature/fast-frame branch from 5c3eb72 to 8dc8c69 Compare May 12, 2020 17:36
@SamanthaAO SamanthaAO force-pushed the users/v-sorcut/website-hover-card-wc branch 3 times, most recently from 669cf0c to 8453bb5 Compare May 12, 2020 23:56
Copy link
Contributor

@nicholasrice nicholasrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with above changes.

@eljefe223
Copy link
Contributor

This should also be a feat not a chore

@SamanthaAO SamanthaAO changed the title chore: create content-card component for marketing site feat: create content-placement component for marketing site May 13, 2020
@SamanthaAO SamanthaAO force-pushed the users/v-sorcut/website-hover-card-wc branch from 0f6a348 to eacd1d3 Compare May 13, 2020 17:46
@SamanthaAO SamanthaAO force-pushed the users/v-sorcut/website-hover-card-wc branch from eacd1d3 to dd8f8a3 Compare May 13, 2020 19:22
@khamudom
Copy link
Contributor

khamudom commented May 13, 2020

Just an FYI. Looks like you can get into a state where all cards blurred. By hover over the edge of the section.
image

@SamanthaAO
Copy link
Contributor Author

That is because currently the whole site uses a grid so on the left and right there is a section where the container is a bit larger than the cards because of how the grid is set up. If the overall layout is changed to flex then the container could be the same size as the cards instead of being the size of the column in the grid that it is defined as. I did not want to make a change to the overall layout at this time with this component, but it is definitely something that should be addressed.

@SamanthaAO SamanthaAO merged commit 6f3af9e into feature/fast-frame May 13, 2020
@SamanthaAO SamanthaAO deleted the users/v-sorcut/website-hover-card-wc branch May 13, 2020 20:09
chrisdholt pushed a commit that referenced this pull request May 13, 2020
* add hover-card component

* add components to index.html, update component index exports to include hover-card, update main styles so that cards wrap

* updated style to be more layout centric

* rename component and update spacing in styles

* change component name to content-placement

* made style updates so all cards are the same height and body stretches

* replace FAST prefix with site

* update divider attribute to boolean mode and remove true for divider in public index

* updated styles to work woth changes in feature and changes icon styling so there is no unneeded space when slot is not used

* update color for links to match figma using design system
chrisdholt pushed a commit that referenced this pull request May 15, 2020
* add hover-card component

* add components to index.html, update component index exports to include hover-card, update main styles so that cards wrap

* updated style to be more layout centric

* rename component and update spacing in styles

* change component name to content-placement

* made style updates so all cards are the same height and body stretches

* replace FAST prefix with site

* update divider attribute to boolean mode and remove true for divider in public index

* updated styles to work woth changes in feature and changes icon styling so there is no unneeded space when slot is not used

* update color for links to match figma using design system
chrisdholt pushed a commit that referenced this pull request May 18, 2020
* add hover-card component

* add components to index.html, update component index exports to include hover-card, update main styles so that cards wrap

* updated style to be more layout centric

* rename component and update spacing in styles

* change component name to content-placement

* made style updates so all cards are the same height and body stretches

* replace FAST prefix with site

* update divider attribute to boolean mode and remove true for divider in public index

* updated styles to work woth changes in feature and changes icon styling so there is no unneeded space when slot is not used

* update color for links to match figma using design system
radium-v pushed a commit that referenced this pull request May 18, 2020
* add hover-card component

* add components to index.html, update component index exports to include hover-card, update main styles so that cards wrap

* updated style to be more layout centric

* rename component and update spacing in styles

* change component name to content-placement

* made style updates so all cards are the same height and body stretches

* replace FAST prefix with site

* update divider attribute to boolean mode and remove true for divider in public index

* updated styles to work woth changes in feature and changes icon styling so there is no unneeded space when slot is not used

* update color for links to match figma using design system
chrisdholt pushed a commit that referenced this pull request May 18, 2020
* add hover-card component

* add components to index.html, update component index exports to include hover-card, update main styles so that cards wrap

* updated style to be more layout centric

* rename component and update spacing in styles

* change component name to content-placement

* made style updates so all cards are the same height and body stretches

* replace FAST prefix with site

* update divider attribute to boolean mode and remove true for divider in public index

* updated styles to work woth changes in feature and changes icon styling so there is no unneeded space when slot is not used

* update color for links to match figma using design system
chrisdholt pushed a commit that referenced this pull request Jun 4, 2020
* add hover-card component

* add components to index.html, update component index exports to include hover-card, update main styles so that cards wrap

* updated style to be more layout centric

* rename component and update spacing in styles

* change component name to content-placement

* made style updates so all cards are the same height and body stretches

* replace FAST prefix with site

* update divider attribute to boolean mode and remove true for divider in public index

* updated styles to work woth changes in feature and changes icon styling so there is no unneeded space when slot is not used

* update color for links to match figma using design system
chrisdholt pushed a commit that referenced this pull request Jun 11, 2020
* add hover-card component

* add components to index.html, update component index exports to include hover-card, update main styles so that cards wrap

* updated style to be more layout centric

* rename component and update spacing in styles

* change component name to content-placement

* made style updates so all cards are the same height and body stretches

* replace FAST prefix with site

* update divider attribute to boolean mode and remove true for divider in public index

* updated styles to work woth changes in feature and changes icon styling so there is no unneeded space when slot is not used

* update color for links to match figma using design system
chrisdholt pushed a commit that referenced this pull request Jun 16, 2020
* add hover-card component

* add components to index.html, update component index exports to include hover-card, update main styles so that cards wrap

* updated style to be more layout centric

* rename component and update spacing in styles

* change component name to content-placement

* made style updates so all cards are the same height and body stretches

* replace FAST prefix with site

* update divider attribute to boolean mode and remove true for divider in public index

* updated styles to work woth changes in feature and changes icon styling so there is no unneeded space when slot is not used

* update color for links to match figma using design system
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants