Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: load all the fast-components #3062

Merged
merged 3 commits into from
May 5, 2020
Merged

chore: load all the fast-components #3062

merged 3 commits into from
May 5, 2020

Conversation

radium-v
Copy link
Collaborator

@radium-v radium-v commented May 5, 2020

Description

Load fast-components for consumption on the website project.

Motivation & context

This shoehorns all WCs available, we should probably reduce this from loading all to just the ones we need in the future.

Issue type checklist

  • Chore: A change that does not impact distributed packages.
  • Bug fix: A change that fixes an issue, link to the issue above.
  • New feature: A change that adds functionality.

Is this a breaking change?

  • This change causes current functionality to break.

Process & policy checklist

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

@radium-v radium-v requested a review from eljefe223 May 5, 2020 17:50
@radium-v radium-v force-pushed the users/jokreitl/fast-frame-components branch from b866a22 to c3175bf Compare May 5, 2020 17:56
nicholasrice
nicholasrice approved these changes May 5, 2020
View reviewed changes
Copy link
Contributor

@nicholasrice nicholasrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed off presuming this still works in prod builds.

@radium-v radium-v force-pushed the users/jokreitl/fast-frame-components branch from 82e3742 to a450e0b Compare May 5, 2020 18:42
@radium-v radium-v requested a review from nicholasrice May 5, 2020 18:49
@chrisdholt chrisdholt force-pushed the feature/fast-frame branch from c29cbb3 to ab229dd Compare May 5, 2020 19:06
@radium-v radium-v force-pushed the users/jokreitl/fast-frame-components branch from a450e0b to 6fbc846 Compare May 5, 2020 19:12
nicholasrice
nicholasrice approved these changes May 5, 2020
View reviewed changes
Copy link
Contributor

@nicholasrice nicholasrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why my approval got pulled off but approving again :)

@chrisdholt chrisdholt merged commit 8c2f48f into feature/fast-frame May 5, 2020
@chrisdholt chrisdholt deleted the users/jokreitl/fast-frame-components branch May 5, 2020 23:23
radium-v added a commit that referenced this pull request May 7, 2020
@radium-v
chore: load all the fast-components (#3062)
487728a 
* Load all the fast-components

* Add custom fast-elements structure

* Fix prod folder output and add build command
chrisdholt pushed a commit that referenced this pull request May 7, 2020
@radium-v @chrisdholt
chore: load all the fast-components (#3062)
a70661a 
* Load all the fast-components

* Add custom fast-elements structure

* Fix prod folder output and add build command
chrisdholt pushed a commit that referenced this pull request May 8, 2020
@radium-v @chrisdholt
chore: load all the fast-components (#3062)
6a68145 
* Load all the fast-components

* Add custom fast-elements structure

* Fix prod folder output and add build command
chrisdholt pushed a commit that referenced this pull request May 11, 2020
@radium-v @chrisdholt
chore: load all the fast-components (#3062)
e757987 
* Load all the fast-components

* Add custom fast-elements structure

* Fix prod folder output and add build command
chrisdholt pushed a commit that referenced this pull request May 12, 2020
@radium-v @chrisdholt
chore: load all the fast-components (#3062)
64f6f25 
* Load all the fast-components

* Add custom fast-elements structure

* Fix prod folder output and add build command
chrisdholt pushed a commit that referenced this pull request May 13, 2020
@radium-v @chrisdholt
chore: load all the fast-components (#3062)
5dbd89b 
* Load all the fast-components

* Add custom fast-elements structure

* Fix prod folder output and add build command
chrisdholt pushed a commit that referenced this pull request May 15, 2020
@radium-v @chrisdholt
chore: load all the fast-components (#3062)
958df39 
* Load all the fast-components

* Add custom fast-elements structure

* Fix prod folder output and add build command
chrisdholt pushed a commit that referenced this pull request May 18, 2020
@radium-v @chrisdholt
chore: load all the fast-components (#3062)
7c72ecb 
* Load all the fast-components

* Add custom fast-elements structure

* Fix prod folder output and add build command
radium-v added a commit that referenced this pull request May 18, 2020
@radium-v
chore: load all the fast-components (#3062)
a020ccf 
* Load all the fast-components

* Add custom fast-elements structure

* Fix prod folder output and add build command
chrisdholt pushed a commit that referenced this pull request May 18, 2020
@radium-v @chrisdholt
chore: load all the fast-components (#3062)
eef49de 
* Load all the fast-components

* Add custom fast-elements structure

* Fix prod folder output and add build command
chrisdholt pushed a commit that referenced this pull request Jun 4, 2020
@radium-v @chrisdholt
chore: load all the fast-components (#3062)
6332431 
* Load all the fast-components

* Add custom fast-elements structure

* Fix prod folder output and add build command
chrisdholt pushed a commit that referenced this pull request Jun 11, 2020
@radium-v @chrisdholt
chore: load all the fast-components (#3062)
ff9a1db 
* Load all the fast-components

* Add custom fast-elements structure

* Fix prod folder output and add build command
chrisdholt pushed a commit that referenced this pull request Jun 16, 2020
@radium-v @chrisdholt
chore: load all the fast-components (#3062)
83a3aa6 
* Load all the fast-components

* Add custom fast-elements structure

* Fix prod folder output and add build command
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khamudom khamudom khamudom approved these changes

@nicholasrice nicholasrice nicholasrice approved these changes

@eljefe223 eljefe223 Awaiting requested review from eljefe223

@chrisdholt chrisdholt Awaiting requested review from chrisdholt

@janechu janechu Awaiting requested review from janechu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@radium-v @nicholasrice @khamudom @chrisdholt