Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add new marketing website #3060

Merged
merged 4 commits into from
May 5, 2020

Conversation

eljefe223
Copy link
Contributor

@eljefe223 eljefe223 commented May 5, 2020

Description

Creates an initial project to start work on new website

Issue type checklist

  • Chore: A change that does not impact distributed packages.
  • Bug fix: A change that fixes an issue, link to the issue above.
  • New feature: A change that adds functionality.

Is this a breaking change?

  • This change causes current functionality to break.

Process & policy checklist

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

@eljefe223 eljefe223 requested a review from janechu as a code owner May 5, 2020 00:04
@eljefe223 eljefe223 requested a review from awentzel May 5, 2020 00:06
Copy link
Member

@chrisdholt chrisdholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One primary concern - the intent here is for the new website, not fast-frame concept :)

sites/fast-frame/package.json Outdated Show resolved Hide resolved
@eljefe223 eljefe223 requested a review from Falkicon as a code owner May 5, 2020 00:55
@eljefe223 eljefe223 dismissed chrisdholt’s stale review May 5, 2020 01:44

have approvals

Copy link
Collaborator

@awentzel awentzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I spoke with Jeff and we agree to put this in its own folder to reduce the risk of issues and concerns I had that would increase PR review times.

Also, I updated all branch policies to remove Circle CI and use GH Actions. If there are adjustments you'd like made to features/* let me know.

@eljefe223 eljefe223 changed the title chore: Sets up initial fast-frame project chore: Sets up initial new website project May 5, 2020
@eljefe223 eljefe223 force-pushed the users/jes/fast-frame-intial-setup branch from 3bdbcc1 to 5be35fb Compare May 5, 2020 02:30
@EisenbergEffect
Copy link
Contributor

@chrisdholt This is actually what I've been working on in bits and pieces. I have a full setup for the new site already. The only piece I'm missing is the reference documentation, which I was hoping to finish tomorrow. It's all Docusaurus v2 based. There's just a placeholder for the new home page that needs to be filled in once we're ready to build that.

@EisenbergEffect
Copy link
Contributor

Just synced with @chrisdholt to confirm that @eljefe223 and company should continue on this work and I'll continue on mine. We'll bring the two together when they are ready. It should be pretty easy to drop a custom home page into the Docusaurus setup I'm working on, which will give us a nice unification of the marketing piece with the docs.

@awentzel awentzel changed the title chore: Sets up initial new website project chore: add new marketing website May 5, 2020
@eljefe223 eljefe223 force-pushed the users/jes/fast-frame-intial-setup branch from 5be35fb to 2e1bffd Compare May 5, 2020 13:53
@eljefe223 eljefe223 merged commit c29cbb3 into feature/fast-frame May 5, 2020
@eljefe223 eljefe223 deleted the users/jes/fast-frame-intial-setup branch May 5, 2020 14:55
eljefe223 added a commit that referenced this pull request May 5, 2020
* feat: allow linked data attached to other linked data to be added to a data dictionary (#3049)

* add eisenberg as codeowner (#3055)

* Sets up intial fast-frame project

* restored website files and renamed new site

Co-authored-by: Jane Chu <[email protected]>
Co-authored-by: Aaron Wentzel <[email protected]>
chrisdholt pushed a commit that referenced this pull request May 5, 2020
* feat: allow linked data attached to other linked data to be added to a data dictionary (#3049)

* add eisenberg as codeowner (#3055)

* Sets up intial fast-frame project

* restored website files and renamed new site

Co-authored-by: Jane Chu <[email protected]>
Co-authored-by: Aaron Wentzel <[email protected]>
radium-v pushed a commit that referenced this pull request May 7, 2020
* feat: allow linked data attached to other linked data to be added to a data dictionary (#3049)

* add eisenberg as codeowner (#3055)

* Sets up intial fast-frame project

* restored website files and renamed new site

Co-authored-by: Jane Chu <[email protected]>
Co-authored-by: Aaron Wentzel <[email protected]>
chrisdholt pushed a commit that referenced this pull request May 7, 2020
* feat: allow linked data attached to other linked data to be added to a data dictionary (#3049)

* add eisenberg as codeowner (#3055)

* Sets up intial fast-frame project

* restored website files and renamed new site

Co-authored-by: Jane Chu <[email protected]>
Co-authored-by: Aaron Wentzel <[email protected]>
chrisdholt pushed a commit that referenced this pull request May 8, 2020
* feat: allow linked data attached to other linked data to be added to a data dictionary (#3049)

* add eisenberg as codeowner (#3055)

* Sets up intial fast-frame project

* restored website files and renamed new site

Co-authored-by: Jane Chu <[email protected]>
Co-authored-by: Aaron Wentzel <[email protected]>
chrisdholt pushed a commit that referenced this pull request May 11, 2020
* feat: allow linked data attached to other linked data to be added to a data dictionary (#3049)

* add eisenberg as codeowner (#3055)

* Sets up intial fast-frame project

* restored website files and renamed new site

Co-authored-by: Jane Chu <[email protected]>
Co-authored-by: Aaron Wentzel <[email protected]>
chrisdholt pushed a commit that referenced this pull request May 12, 2020
* feat: allow linked data attached to other linked data to be added to a data dictionary (#3049)

* add eisenberg as codeowner (#3055)

* Sets up intial fast-frame project

* restored website files and renamed new site

Co-authored-by: Jane Chu <[email protected]>
Co-authored-by: Aaron Wentzel <[email protected]>
chrisdholt pushed a commit that referenced this pull request May 13, 2020
* feat: allow linked data attached to other linked data to be added to a data dictionary (#3049)

* add eisenberg as codeowner (#3055)

* Sets up intial fast-frame project

* restored website files and renamed new site

Co-authored-by: Jane Chu <[email protected]>
Co-authored-by: Aaron Wentzel <[email protected]>
chrisdholt pushed a commit that referenced this pull request May 15, 2020
* feat: allow linked data attached to other linked data to be added to a data dictionary (#3049)

* add eisenberg as codeowner (#3055)

* Sets up intial fast-frame project

* restored website files and renamed new site

Co-authored-by: Jane Chu <[email protected]>
Co-authored-by: Aaron Wentzel <[email protected]>
chrisdholt pushed a commit that referenced this pull request May 18, 2020
* feat: allow linked data attached to other linked data to be added to a data dictionary (#3049)

* add eisenberg as codeowner (#3055)

* Sets up intial fast-frame project

* restored website files and renamed new site

Co-authored-by: Jane Chu <[email protected]>
Co-authored-by: Aaron Wentzel <[email protected]>
radium-v pushed a commit that referenced this pull request May 18, 2020
* feat: allow linked data attached to other linked data to be added to a data dictionary (#3049)

* add eisenberg as codeowner (#3055)

* Sets up intial fast-frame project

* restored website files and renamed new site

Co-authored-by: Jane Chu <[email protected]>
Co-authored-by: Aaron Wentzel <[email protected]>
chrisdholt pushed a commit that referenced this pull request May 18, 2020
* feat: allow linked data attached to other linked data to be added to a data dictionary (#3049)

* add eisenberg as codeowner (#3055)

* Sets up intial fast-frame project

* restored website files and renamed new site

Co-authored-by: Jane Chu <[email protected]>
Co-authored-by: Aaron Wentzel <[email protected]>
chrisdholt pushed a commit that referenced this pull request Jun 4, 2020
* feat: allow linked data attached to other linked data to be added to a data dictionary (#3049)

* add eisenberg as codeowner (#3055)

* Sets up intial fast-frame project

* restored website files and renamed new site

Co-authored-by: Jane Chu <[email protected]>
Co-authored-by: Aaron Wentzel <[email protected]>
chrisdholt pushed a commit that referenced this pull request Jun 11, 2020
* feat: allow linked data attached to other linked data to be added to a data dictionary (#3049)

* add eisenberg as codeowner (#3055)

* Sets up intial fast-frame project

* restored website files and renamed new site

Co-authored-by: Jane Chu <[email protected]>
Co-authored-by: Aaron Wentzel <[email protected]>
chrisdholt pushed a commit that referenced this pull request Jun 16, 2020
* feat: allow linked data attached to other linked data to be added to a data dictionary (#3049)

* add eisenberg as codeowner (#3055)

* Sets up intial fast-frame project

* restored website files and renamed new site

Co-authored-by: Jane Chu <[email protected]>
Co-authored-by: Aaron Wentzel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants