feat: simplify array UI by removing the dropdown menu #1250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisdholt
reviewed
Dec 29, 2018
packages/fast-form-generator-react/src/form/form-item.array.style.ts
Outdated
Show resolved
Hide resolved
chrisdholt
reviewed
Dec 29, 2018
packages/fast-form-generator-react/src/form/form-item.children.style.ts
Outdated
Show resolved
Hide resolved
chrisdholt
approved these changes
Dec 30, 2018
eljefe223
approved these changes
Dec 31, 2018
janechu
merged commit bef808f
into
features/update-form-generator-ui-for-arrays-and-children
8 tasks
This was referenced Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change updates the handling of the array data type in the
fast-form-generator-reactpackage to use a simplified method of controlling it and removes the drop down menu.This change will go into a feature branch which also addresses a UI change for the handling of the React children data type.
Motivation & context
This simplifies the UI for adding and removing array items.
Issue type checklist
Is this a breaking change?
[ ] This change causes current functionality to break.
Process & policy checklist