Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WCAG 4.1.2: Ensures ARIA attributes are allowed for an element's role (fast-radio) #6437

Closed
yinonov opened this issue Oct 9, 2022 · 2 comments

Comments

@yinonov
Copy link
Contributor

yinonov commented Oct 9, 2022

Issue

Ensures ARIA attributes are allowed for an element's role (aria-allowed-attr)

Target application

FAST

Element path

iframe;fast-radio

Snippet

<fast-radio readonly="" role="radio" class="readonly" aria-checked="false" aria-required="false" aria-disabled="false" aria-readonly="true" tabindex="0" current-value="on" current-checked="false">Label</fast-radio>

How to fix

Fix any of the following:
  ARIA attribute is not allowed: aria-readonly="true"

Environment

Chrome version 105.0.0.0
This accessibility issue was found using Accessibility Insights for Web 2.35.0 (axe-core 4.4.1), a tool that helps find and fix accessibility issues. Get more information & download this tool at http://aka.ms/AccessibilityInsights.

@yinonov
Copy link
Contributor Author

yinonov commented Oct 9, 2022

this was generated by accessibility insight chrome extension
image

yinonov added a commit to yinonov/fast that referenced this issue Oct 9, 2022
readonly on radio button violates a WCAG rule. see microsoft#6437

there's no evidence readonly applies on radio button. it does on radio group however

- [aria-readonly associated roles on MDN](https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-readonly#associated_roles) doesn’t list radio
- https://stackoverflow.com/questions/1953017/why-cant-radio-buttons-be-readonly
- https://www.w3schools.com/jsref/dom_obj_radio.asp
chrisdholt added a commit that referenced this issue Mar 10, 2023
* fix(foundation): remove readonly from radio button

readonly on radio button violates a WCAG rule. see #6437

there's no evidence readonly applies on radio button. it does on radio group however

- [aria-readonly associated roles on MDN](https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-readonly#associated_roles) doesn’t list radio
- https://stackoverflow.com/questions/1953017/why-cant-radio-buttons-be-readonly
- https://www.w3schools.com/jsref/dom_obj_radio.asp

* remove any evidence of readonly from class

* completely remove any readonly

* Change files

* group slotted radio readonly handling

* docs update

* Update change/@microsoft-fast-foundation-b9885563-e3e8-4c85-a55d-bac04c627fec.json

Co-authored-by: Nicholas Rice <[email protected]>

* Update change/@microsoft-fast-foundation-b9885563-e3e8-4c85-a55d-bac04c627fec.json

Co-authored-by: Nicholas Rice <[email protected]>

* prevent check of radio buttons

* Update packages/web-components/fast-foundation/src/radio/radio.ts

Co-authored-by: Nicholas Rice <[email protected]>

* revert

* remove unused

* FASTRadioGroup to be used as type only

* fixup prettier and API report

---------

Co-authored-by: Nicholas Rice <[email protected]>
Co-authored-by: Rob Eisenberg <[email protected]>
Co-authored-by: Chris Holt <[email protected]>
@janechu
Copy link
Collaborator

janechu commented May 29, 2024

It appears this was fixed in #6438

@janechu janechu closed this as completed May 29, 2024
janechu pushed a commit that referenced this issue Jun 10, 2024
* fix(foundation): remove readonly from radio button

readonly on radio button violates a WCAG rule. see #6437

there's no evidence readonly applies on radio button. it does on radio group however

- [aria-readonly associated roles on MDN](https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-readonly#associated_roles) doesn’t list radio
- https://stackoverflow.com/questions/1953017/why-cant-radio-buttons-be-readonly
- https://www.w3schools.com/jsref/dom_obj_radio.asp

* remove any evidence of readonly from class

* completely remove any readonly

* Change files

* group slotted radio readonly handling

* docs update

* Update change/@microsoft-fast-foundation-b9885563-e3e8-4c85-a55d-bac04c627fec.json

Co-authored-by: Nicholas Rice <[email protected]>

* Update change/@microsoft-fast-foundation-b9885563-e3e8-4c85-a55d-bac04c627fec.json

Co-authored-by: Nicholas Rice <[email protected]>

* prevent check of radio buttons

* Update packages/web-components/fast-foundation/src/radio/radio.ts

Co-authored-by: Nicholas Rice <[email protected]>

* revert

* remove unused

* FASTRadioGroup to be used as type only

* fixup prettier and API report

---------

Co-authored-by: Nicholas Rice <[email protected]>
Co-authored-by: Rob Eisenberg <[email protected]>
Co-authored-by: Chris Holt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants