Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

focusStrokeWidth not applied on text-field and number-field #5565

Closed
fcollonval opened this issue Feb 6, 2022 · 1 comment · Fixed by #5566
Closed

focusStrokeWidth not applied on text-field and number-field #5565

fcollonval opened this issue Feb 6, 2022 · 1 comment · Fixed by #5566
Labels
bug A bug community:good-first-issue Good issues for first time contributors

Comments

@fcollonval
Copy link
Contributor

In text field and number field the box-shadow width is constant

fast/packages/web-components/fast-components/src/text-field/text-field.styles.ts

Line 130 in 3337629

box-shadow: 0 0 0 1px ${focusStrokeOuter} inset;

But in select it is using the design token focusStrokeWidth

fast/packages/web-components/fast-components/src/select/select.styles.ts

Line 107 in 3337629

box-shadow: 0 0 0 calc(${focusStrokeWidth} * 1px) ${focusStrokeOuter};

What is the reason behind that discrepancy?
@chrisdholt
Copy link
Member

Looks like a bug, thanks for filing!

@chrisdholt chrisdholt added area:fast-components bug A bug community:good-first-issue Good issues for first time contributors labels Feb 6, 2022
fcollonval added a commit to fcollonval/fast that referenced this issue Feb 7, 2022
@fcollonval
focusStrokeWidth not applied on text-field and number-field
64645f6 
Fixes microsoft#5565
@fcollonval fcollonval mentioned this issue Feb 7, 2022
Merged
5 tasks
chrisdholt pushed a commit that referenced this issue Feb 7, 2022
@fcollonval
focusStrokeWidth not applied on text-field and number-field (#5566)
ec5ceae 
* `focusStrokeWidth` not applied on text-field and number-field
Fixes #5565

* Change files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug A bug community:good-first-issue Good issues for first time contributors
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

focusStrokeWidth not applied on text-field and number-field fcollonval/fast
2 participants
@fcollonval @chrisdholt