Skip to content
This repository has been archived by the owner on Feb 15, 2022. It is now read-only.

Remove automatic addition of stable repo #321

Merged
merged 2 commits into from
Nov 2, 2020
Merged

Remove automatic addition of stable repo #321

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6de29f9
Update stable repo to https://charts.helm.sh/stable
timfpark Nov 2, 2020
ee72896
Remove adding stable repo by default
timfpark Nov 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions cmd/install.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,15 +24,6 @@ func Install(path string) (err error) {
logger.Info(emoji.Sprintf(":mag: Using %s: %s", tool, path))
}

// By default, Helm 2 used to have the "stable" repo. This is assumed
// to exist in Fabrikate as a non-http repo.
// See timeline/deprecation schedule: https://github.com/helm/charts
logger.Info(emoji.Sprintf(":point_right: Adding stable repository"))
if output, err := exec.Command("helm", "repo", "add", "stable", "https://kubernetes-charts.storage.googleapis.com").CombinedOutput(); err != nil {
logger.Error(emoji.Sprintf(":no_entry_sign: %s: %s", err, output))
return err
}

rootInit := func(startingPath string, environments []string, c core.Component) (component core.Component, err error) {
return c.InstallRoot(startingPath, environments)
}
Expand Down Expand Up @@ -85,7 +76,7 @@ func Install(path string) (err error) {
var installCmd = &cobra.Command{
Use: "install",
Short: "Installs all of the remote components specified in the current deployment tree locally",
Long: `Installs all of the remote components specified in the current deployment tree locally, iterating the
Long: `Installs all of the remote components specified in the current deployment tree locally, iterating the
component subtree from the current directory to do so. Required to be executed before generate (if needed), such
that Fabrikate has all of the dependencies locally to use to generate the resource manifests.`,
RunE: func(cmd *cobra.Command, args []string) (err error) {
Expand Down