Skip to content
This repository has been archived by the owner on Feb 15, 2022. It is now read-only.

added daily builds at midnight #298

Merged
merged 1 commit into from
Apr 27, 2020
Merged

added daily builds at midnight #298

merged 1 commit into from
Apr 27, 2020

Conversation

michaelperel
Copy link
Contributor

  • Daily builds ensure that code on master will not go stale, even if no new changes were introduced
  • Will ensure that contributors can know the status of tests on master, always
  • Here is a link to the AZDO docs for schedules to read more

@michaelperel
Copy link
Contributor Author

@evanlouie @timfpark I opened this PR because when I started contributing on the helm 3 PR, tests were failing on master despite the badge in the README showing they passed. It was difficult at first to contribute because I thought I had done something wrong when setting up the project.

In that PR, I fix the logic of the broken tests as part of the helm 3 upgrade.

In this PR, I suggest adding a nightly build so these problems can be caught/it becomes easier for people to contribute.

This means that this PR will fail, since master is failing. I figure this could be merged once the helm 3 PR is merged.

Thanks!

@evanlouie
Copy link
Contributor

thanks for the PR! any reason you can think of we shouldn't merge now?

@michaelperel
Copy link
Contributor Author

@evanlouie I think it should be merged, I just wasn't sure if it would be possible given that the build is failing. If you are able to, I am all for it!

@evanlouie evanlouie merged commit 5c8cc86 into microsoft:master Apr 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants