This repository has been archived by the owner on Feb 15, 2022. It is now read-only.
Fixed permission denied regression
#257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed an error which would occur if a user attempted to `install` a component which already previously been installed. This was caused do to being unable to overwrite existing files in the installed components `.git` directory. The previously installed component is now deleted prior to copying from the clone cache.
evanlouie
commented
Sep 9, 2019
| // Clone and get the location of where it was cloned to in tmp | ||
| result := <-cache.cloneRepo(repo, commit, branch) | ||
| clonePath := result.get() | ||
| if result.Error != nil { | ||
| return result.Error | ||
| } | ||
|
|
||
| // Remove the into directory if it already exists | ||
| if err = os.RemoveAll(intoPath); err != nil { |
evanlouie
commented
Sep 9, 2019
| @@ -315,6 +315,11 @@ func (hd *helmDownloader) downloadChart(repo, chart, version, into string) (err | |||
| } | |||
| hd.mu.Unlock() | |||
|
|
|||
| // Remove the into directory if it already exists | |||
| if err = os.RemoveAll(into); err != nil { | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
installa component which already previously been installed. This was caused do to being unable to overwrite existing files in the installed components.gitdirectory. The previously installed component is now deleted prior to copying from the clone cache.fixes #228