Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correction misinterpretation of Presentation Exchange for OpenID #60

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

logangirvin
Copy link
Contributor

Problem:
While adding support for multiple vp_token responses, changes were made to parsing requests to allow multiple presentation definitions in the open_id request and treat each presentation definition as an independent vp_token. This change was not within specification and should be removed.

Solution:
Removed support for multiple presentation_definition objects in open id requests.

Validation:
Manually validated against application code.

Type of change:

  • Feature work
  • Bug fix
  • Documentation
  • Engineering change
  • Test
  • Logging/Telemetry

Risk:

  • High – Errors could cause MAJOR regression of many scenarios. (Example: new large features or high level infrastructure changes)
  • Medium – Errors could cause regression of 1 or more scenarios. (Example: somewhat complex bug fixes, small new features)
  • Small – No issues are expected. (Example: Very small bug fixes, string changes, or configuration settings changes)

Work Item links:

Documentation Links:
https://openid.net/specs/openid-4-verifiable-presentations-1_0.html#name-authorization-request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant