Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symorton/issuance cancel method #26

Merged
merged 13 commits into from
Mar 27, 2023
Merged

Conversation

symorton
Copy link
Contributor

  • Add Issuance Callback logic to VerifiedIdIssuanceRequest. We will automatically call the issuance callback during complete for a success of failure. For the cancel method on the VerifiedIdIssuanceRequest, we will call the issuance callback with error message of "user canceled" because that is the only one Client API supports for canceled flows.
  • We need to get the state and the callback url from the PresentationRequest and inject it into the IssuanceRequest like we do for InjectedIdToken.
  • Added test cases for all of the above.

@symorton symorton requested a review from nithyaganeshng March 24, 2023 20:48
Copy link

@nithyaganeshng nithyaganeshng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you implement the same for issuance request fetch as well?

@symorton symorton merged commit 3445b0b into dev Mar 27, 2023
@symorton symorton deleted the symorton/issuanceCancelMethod branch March 27, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants