Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split up issuance and presentation request content data models #18

Merged
merged 336 commits into from
Mar 14, 2023
Merged

Split up issuance and presentation request content data models #18

merged 336 commits into from
Mar 14, 2023

Conversation

symorton
Copy link
Contributor

@symorton symorton commented Mar 9, 2023 •
edited
Loading

Builds off of PR #17

  • Create an extension for VCSDK.PresentationResponseContainer that mirrors the extension for VCSDK.IssuanceResponseContainer.
  • Created a PresentationResponse protocol that defines a behavior for VCSDK.PresentationResponseContainer to help with unit testing.
  • Split VerifiedIdContent into two separate data models: one for issuance and one for presentation.
  • Renamed OpenIdForVCResponder to OpenIdResponder because "ForVC" is redundant. Will update the name of Resolver in next PR.
  • Removed raw value from OpenIdRawRequest as it was not used/needed.
  • Moved a couple of files around.
  • Included raw presentation request to OpenIdPresentationRequest params as it will be needed to complete the request.
  • Fix tests with new data model names.
  • Add tests for VCSDK.PresentationResponseContainer extension and IssuanceRequestContent.

@symorton
Update OpenIdURLRequestResolverTests.swift
0983578
@symorton
Create MockLogConsumer.swift
63ca6ee
@symorton
Add mock verified id request.
396e2ca
@symorton
Make handleRequest function generic instead of using associated type
7805146
@symorton
Implement createVerifiedIdRequest
9d38bf6
@symorton
Update mocks.
040dfd3
@symorton
complete test cases for VerifiedIdClientTests
d87caad
@symorton
Fix nits for PR
5b57d3a
@symorton
Merge branch 'dev' into symorton/implementCreateVerifiedIdRequest
806f233
@symorton
Extend VC SDK Issuance service.
de7d9a5
@symorton
Create protocol for Contract Resolver to use to extend issuance service.
ba8b5ca
@symorton
Create a raw contract protocol that conforms to mappable.
a0f825a
@symorton
Update VerifiedIdRequest.swift
47d8f0c
@symorton
Delete Contract.swift
305bd0f
@symorton
Implement issuance request logic in open id request handler.
b04af6a
@symorton
Create ContractIssuanceRequest.swift
c8376fb
@symorton
add contract resolver param to open id handler
0760996
@symorton
Add Raw Contract as an extension of Issuance Request.
e7f0700
@symorton
Update IssuanceService+Contract.swift
efd088f
@symorton
Update ContractResolver.swift
ce3a401
@symorton
Update ContractIssuanceRequest.swift
f6342a2
@symorton
Create MockContractResolver.swift
eb98a71
@symorton
Add test cases for issuance flow in open id request handler tests.
14945c1
@symorton
Update OpenIdURLRequestResolverTests.swift
ada5a2f
@symorton
Add period to comment.
bc37bfa
@symorton
Create AttestationsDescriptor mapper
3ff9f6b
@symorton
Update IssuanceRequest+RawContract.swift
e70c873
@symorton
GroupRequirement only supports .ALL
35c234c
@symorton
add comment about pin to OpenIdRequestHandler.
13f48d8
@symorton
add comment to verified id request content.
4f45767
symorton added 17 commits March 8, 2023 16:12
@symorton
Remove RawRequest idea from OpenIdRawRequest.
d38bb1e
@symorton
Fix comment in openIdResponder.
d2c6432
@symorton
Fix naming in OpenIdRequestHandler.
34033de
@symorton
Update AttestationsDescriptor+MappableTests.swift
1d362d5
@symorton
Update PresentationDefinition+MappableTests.swift
9312fbb
@symorton
Move factories to different folder.
f2b6255
@symorton
Split up Issuance and Presentation Request Content.
c7a1993
@symorton
Fix mock resolver.
d5f123e
@symorton
Update name of param in OpenIdRequestHandler.
d468dec
@symorton
Move some files changes to new PR.
0a38249
@symorton
Create PresentationResponseContainer extension.
471d31e
@symorton
Remove code to be added in next pr.
02fac99
@symorton
Fix tests.
0cedd82
@symorton
Add placeholder files for extension and content tests.
9f574d5
@symorton
Update PresentationResponseContainer+WalletLibrary.swift
88fa301
@symorton
Update IssuanceRequestContent.swift
9ec9826
@symorton
Complete test cases for issuance request content.
463f6d3
@symorton symorton changed the base branch from symorton/testAppPart1 to dev March 9, 2023 17:28
@symorton symorton requested a review from nithyaganeshng March 9, 2023 17:30
@symorton symorton mentioned this pull request Mar 14, 2023
Merged
@symorton symorton merged commit 95739b3 into dev Mar 14, 2023
@symorton symorton deleted the symorton/splitIssuanceAndPresentationRequestContent branch March 14, 2023 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nithyaganeshng nithyaganeshng nithyaganeshng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@symorton @nithyaganeshng