Fix JWK Layer. #124
Open
Fix JWK Layer. #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
logangirvin
reviewed
Nov 15, 2024
| @@ -3,8 +3,8 @@ | |||
| * Licensed under the MIT License. See License.txt in the project root for license information. | |||
| *--------------------------------------------------------------------------------------------*/ | |||
|
|
|||
| /// TODO: deprecate entity for JWK | |||
| public struct ECPublicJwk: Codable, Equatable { | |||
| public struct PublicJWK: Codable, Equatable | |||
There was a problem hiding this comment.
This is still an ECPublicKey. x and y are only on keytype EC.
There was a problem hiding this comment.
Can we just keep the name EcPublicJwk for now and resolve this in a different PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
We need to fix the JWK layer to ensure that the flow works end-to-end and that the tests pass.
Solution:
Rename PublicJWK.
Fix some small nits bugs.
Validation:
All tests updated and passing.
Type of change:
Risk:
Work Item links:
Please include here links for this work item, or deferred work, or related work. E.g. if the refactoring is too big to fit in this PR, or the localized strings need to be updated later, please link the TODO work items here.
Documentation Links:
Please include here links to any related background documentation for this PR.