Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open Id Handler Part 1 #10

Merged
merged 29 commits into from
Feb 9, 2023
Merged

Open Id Handler Part 1 #10

merged 29 commits into from
Feb 9, 2023

Conversation

symorton
Copy link
Contributor

@symorton symorton commented Feb 9, 2023

  • Create Library Configuration to keep track of all utilities set from builder.
  • Make any object that conforms to OpenIdRawRequest (like VCSDK.PresentationRequest) mappable to VerifiedIdRequestContent.
  • Implement OpenIdRequestHandler just for Presentation (Issuance to come in next PR)
  • Unit Test OpenIdRequestHandler as well as create mocks for those tests.

symorton added 26 commits February 9, 2023 08:10
@symorton
Update OpenIdRawRequest.swift
23adf83
@symorton
Update OpenIdRawRequest dependencies
1b6eec9
@symorton
Update OpenIdForVCResolver.swift
35980d5
@symorton
Add OpenIdRequestHandlerTests
2640002
@symorton
Extend PresentationRequest
7694b18
@symorton
Add library configuration
e56382c
@symorton
Update OpenIdRequestHandler.swift
ceb9c58
@symorton
Add mocks
823313b
@symorton
Create OpenIdPresentationRequest.swift
8146ebd
@symorton
Update folder naming for request protocols
424d998
@symorton
Move VerifiedIdRequest to different folder
d00ff6e
@symorton
Revert PresentationDescriptor Mapping
c10d378
@symorton
Move VerifiedIdIssuanceRequest and PresentationRequest out of OpenIdR…
beb4c4d 
…equestHandler
@symorton
Remove old data models.
de63ffc
@symorton
Create RequestType.swift
507a8de
@symorton
Create VerifiedIdRequestContent.swift
3d1899d
@symorton
Add comment to configuration
8e8f579
@symorton
Update PresentationRequest+OpenIdRawRequest.swift
aa07d82
@symorton
Update OpenIdRawRequest.swift
2a77e3c
@symorton
Fix type in presentation request extension.
77e76fb
@symorton
Add comments to Requests.
99b2e18
@symorton
Update MockVerifiedIdRequestContent.swift
5d8eb68
@symorton
Add MockMapper
786cd5d
@symorton
Remove await from private method for presentation request.
74a31d3
@symorton
Update OpenIdRequestHandlerTests.swift
6b26e49
@symorton
Fix nit before pr.
7b04a54
@symorton symorton merged commit 662575d into dev Feb 9, 2023
@symorton symorton deleted the symorton/openidhandler branch February 9, 2023 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kashifm-msft kashifm-msft kashifm-msft approved these changes

@nithyaganeshng nithyaganeshng Awaiting requested review from nithyaganeshng

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@symorton @kashifm-msft