Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended hello-sample #73

Merged
merged 2 commits into from
Sep 20, 2021
Merged

Extended hello-sample #73

merged 2 commits into from
Sep 20, 2021

Conversation

lechnerc77
Copy link
Contributor

This pull request contains the extension of the hello-sample GitHub page section with the information necessary to build, run and deploy the new samples introduced in pull request #72

Copy link
Member

@sebastianburckhardt sebastianburckhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, a big improvement. Love the unicode characters you added: 🚀!

I have some very minor suggestions and found one typo, other than that I think this is ready.

docs/hello-sample.md Outdated Show resolved Hide resolved

5. [Azurite 3.x](https://github.com/Azure/Azurite) as storage emulator for the local execution. You can run `azurite --version` to check what is installed.

6. [An Azure subscription](https://azure.microsoft.com/free/search/), to allocate and deploy the required resources.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you could mention here that it is possible to run the samples local-only without an Azure account?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added that as a remark

docs/hello-sample.md Show resolved Hide resolved

The language-specific folder in the `samples` folder contain "minimal" Azure Durable Functions projects (much like the [DF Quick Start](https://docs.microsoft.com/azure/azure-functions/durable/durable-functions-create-first-csharp?pivots=code-editor-visualstudio)).

⚠ **CAUTION:** Be aware that all projects have no authentication in place. This makes the calling of the Functions easy, but this is not feasible setup for a production environment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

docs/hello-sample.md Outdated Show resolved Hide resolved
@lechnerc77
Copy link
Contributor Author

Made corrections as suggested.

@sebastianburckhardt sebastianburckhardt merged commit e10b10c into microsoft:gh-pages Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants