increase major version (2.0.0) and update packages #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastianburckhardt
changed the title
davidmrdavid
reviewed
Oct 2, 2024
Comment on lines
61
to
62
| <PackageReference Include="Microsoft.SourceLink.GitHub" Version="8.0.0" PrivateAssets="All" /> | ||
| <PackageReference Include="System.Threading.Channels" Version="6.0.0" /> |
There was a problem hiding this comment.
Do we need to upgrade these 2? For maximum bundles compatibility (we'll be releasing this in an existing bundles feed) I'd rather not majorly increase dependencies that we don't strictly need. We'll get another chance, with more time, to see if it's safe to increase this once we consume DF WebJobs V3, so I'd prefer to delay these major version increases until then
There was a problem hiding this comment.
I am getting downgrade warnings if I don't include "System.Threading.Channels" Version="6.0.0" , must be being picked up somewhere. Build fails.
I don't like those warnings, I would rather go to 6.0.0
There was a problem hiding this comment.
I think that:
- I can entirely remove reference to System.Threading.Channels because it is implicitly imported now by EH
- Sourcelink is a build-time only dependency so I don't think there is an issue with keeping it there.
davidmrdavid
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation of the 2.0.0 release: