Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade FASTER dependency to v2.6.4 #344

Merged
merged 12 commits into from
Apr 22, 2024
Merged

Conversation

bachuv
Copy link
Collaborator

@bachuv bachuv commented Feb 7, 2024

This PR includes the following changes:

Copy link
Member

@sebastianburckhardt sebastianburckhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks pretty good. Left some comments.

@sebastianburckhardt sebastianburckhardt changed the base branch from dev to main February 29, 2024 18:27
Copy link
Member

@sebastianburckhardt sebastianburckhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, some very minor changes, and waiting for the updated FASTER.

Then we can merge I think, but before releasing, we will still need to run tests to validate (a) users can keep using their existing task hubs without breaking changes, and (b) that this new version of FASTER can run our workloads without new error popping up.

@sebastianburckhardt sebastianburckhardt added this to the 1.4.3 milestone Mar 5, 2024
@sebastianburckhardt
Copy link
Member

Starting to run some tests now.

@bachuv bachuv marked this pull request as ready for review March 5, 2024 17:58
@sebastianburckhardt sebastianburckhardt changed the title Upgrade FASTER dependency to v2.6.1 Upgrade FASTER dependency to v2.6.2 Mar 5, 2024
@sebastianburckhardt
Copy link
Member

There appears to be a problem with not being able to load v7.0.0 of Microsoft.Extensions.Logging.

I opened a PR to modify FASTER to remain compatible.

@sebastianburckhardt sebastianburckhardt changed the title Upgrade FASTER dependency to v2.6.2 Upgrade FASTER dependency to v2.6.3 Mar 15, 2024
@sebastianburckhardt
Copy link
Member

I did a quick validation that it is possible to open old taskhubs after updating.

However note that the reverse is not true. Once you have opened a task hub with this version, you cannot go back to an older version! We may need to include a warning?

@davidmrdavid
Copy link
Member

@sebastianburckhardt: I don't think we can detect this scenario in Netherite, can we? From looking at the diff, it seems the loading of previous FASTER format is happening at the FASTER level, and our code is oblivious to it, is it not?

Assuming this is the case, I'm personally 'ok' with it. However, I think this should be a minor version increase, not a patch version, since we're updating a dependency and the minor version allows us to signal to users that they should pay extra attention to the release notes.

Copy link
Member

@davidmrdavid davidmrdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit but important: let's please make this a minor version release :) . We're upgrading a dependency and there's implications in terms of backwards compat with previous FASTER storage formats

@sebastianburckhardt
Copy link
Member

@bachuv, I think you can merge this once @davidmrdavid approves.

We should still run more tests before releasing 1.5.0 but it makes sense to test the entire release, not just this PR.

let's please make this a minor version release

I have added a PR #368 to update the version to 1.5.0, so it does not need to be part of this PR.

Copy link
Member

@davidmrdavid davidmrdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 it!

@bachuv
Copy link
Collaborator Author

bachuv commented Mar 19, 2024

@bachuv, I think you can merge this once @davidmrdavid approves.

Okay, I'll merge it once the CI passes.

@sebastianburckhardt
Copy link
Member

Hmm, those CI failures look somewhat concerning given that FASTER has undergone a lot of updates (and therefore possibly contains new bugs). I will take a look at those failures.

@sebastianburckhardt sebastianburckhardt added the P1 Priority 1 label Apr 12, 2024
@sebastianburckhardt sebastianburckhardt changed the title Upgrade FASTER dependency to v2.6.3 Upgrade FASTER dependency to v2.6.4 Apr 16, 2024
@sebastianburckhardt
Copy link
Member

The CI failures were bugs in FASTER which were fixed in microsoft/FASTER#911. We should be able to move forward as soon as FASTER v2.6.4 is released.

@sebastianburckhardt sebastianburckhardt merged commit 6870713 into main Apr 22, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 Priority 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants