-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always release partition lease when a partition shuts down #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidmrdavid
approved these changes
Dec 18, 2023
Comment on lines
739
to
742
|
||
// we always release the lease here, whether the partition has already been terminated or not. | ||
await this.leaseClient.ReleaseAsync(conditions: null, CancellationToken.None).ConfigureAwait(false); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit:
Suggested change
// we always release the lease here, whether the partition has already been terminated or not. | |
await this.leaseClient.ReleaseAsync(conditions: null, CancellationToken.None).ConfigureAwait(false); | |
// we always release the lease here, whether the partition has already been terminated or not. | |
// otherwise, a pending client request for that partition will be delayed until the lease expires | |
await this.leaseClient.ReleaseAsync(conditions: null, CancellationToken.None).ConfigureAwait(false); | |
cgillum
approved these changes
Dec 18, 2023
Added two more changes (because of related issues observed when testing this PR).
|
davidmrdavid
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While analyzing some of traces showing high client latencies (see Azure/azure-functions-durable-extension#2603) we discovered a problem: in some cases the partition lease is not released when the partition is terminated, because the request is cancelled. This causes an excessive delay before the partitition recovery, since the lease has to expire first. Waiting for the lease to expire can take up to 40s and delays all pending client requests to that partition.
This PR fixes this problem by not passing the termination cancellation token to the lease renewal (which caused the lease release to not happen).