Copy ParentTraceContext when cloning ExecutionStartedEvent #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidmrdavid
reviewed
Oct 4, 2023
...DurableTask.Netherite/Events/PartitionEvents/External/FromClients/CreationRequestReceived.cs
Show resolved
Hide resolved
* rebase, and remove changes to scale monitor * add hello cities test that prints the history of a nested orchestration
|
@sebastianburckhardt, can we merge this PR to be a part of the v1.4.1 release? |
|
Leaving a note that this PR depends on DT.Core > 2.15.1. |
sebastianburckhardt
approved these changes
Oct 19, 2023
* update DT and DF package references * update to latest
* Update GH automation (#303) * initial commit (#290) * Revert "initial commit (#290)" (#314) This reverts commit 3a2d193. * Bump Azure.Identity from 1.7.0 to 1.10.2 in /samples/TokenCredentialDTFx (#323) Bumps [Azure.Identity](https://github.com/Azure/azure-sdk-for-net) from 1.7.0 to 1.10.2. - [Release notes](https://github.com/Azure/azure-sdk-for-net/releases) - [Commits](Azure/azure-sdk-for-net@Azure.Identity_1.7.0...Azure.Identity_1.10.2) --- updated-dependencies: - dependency-name: Azure.Identity dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Terminate partition when FASTER refuses to checkpoint for over a minute (#301) --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Varshitha Bachu <[email protected]> Co-authored-by: Sebastian Burckhardt <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a line to copy
ExecutionStartedEvent.ParentTraceContextwhen cloningExecutionStartedEventinCreationRequestReceived.Clone(). This change is necessary for Distributed Tracing V2 to work.I created this PR as a draft because a new version of DT.Core needs to be released with a bug fix for this to work so this PR shouldn't be merged until then.