Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix race in memory tracker #254

Merged
merged 2 commits into from
Apr 21, 2023
Merged

Fix race in memory tracker #254

merged 2 commits into from
Apr 21, 2023

Conversation

sebastianburckhardt
Copy link
Member

Can cause divide-by-zero exceptions. It happens quite rarely.

I observed this during long-running testing in the consumption plan.

@sebastianburckhardt sebastianburckhardt changed the title Fix data race in memory tracker Fix race in memory tracker Apr 20, 2023
davidmrdavid
davidmrdavid approved these changes Apr 20, 2023
View reviewed changes
Copy link
Member

@davidmrdavid davidmrdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's quite the race condition! Worth documenting it imo.

src/DurableTask.Netherite/StorageLayer/Faster/MemoryTracker.cs Show resolved Hide resolved
@sebastianburckhardt sebastianburckhardt merged commit 08f823c into dev Apr 21, 2023
sebastianburckhardt added a commit that referenced this pull request Apr 24, 2023
@sebastianburckhardt
fix line that was missed in #254
6e1ec94
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidmrdavid davidmrdavid davidmrdavid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sebastianburckhardt @davidmrdavid