Optimize host shutdown #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidmrdavid
approved these changes
Apr 14, 2023
Comment on lines
+304
to
+308
| this.traceHelper.LogDebug("EventHubsTransport is stopping partition and loadmonitor hosts"); | ||
| await Task.WhenAll( | ||
| this.StopPartitionHostAsync(), | ||
| this.StopLoadMonitorHostAsync()); | ||
| } |
There was a problem hiding this comment.
Do we want a log indicating that the WhenAll completed?
There was a problem hiding this comment.
I think we can skip that one since there is a log statement at the very end of each of the tasks.
Comment on lines
318
to
320
| this.traceHelper.LogDebug("EventHubsTransport is stopping client"); | ||
| await this.client.StopAsync(); | ||
| } |
There was a problem hiding this comment.
do we want a log indicating the client stopped, not just that it began its stop operation?
There was a problem hiding this comment.
yes, that makes sense.
|
hmm, I see the CI is failing though. Is it transient or related to this change? |
|
The CI failures are likely not related. I have seen them a few times already; will work on that separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when the EventHubsTransport shuts down, it shuts down the client and closes the EH connection only after all the workers are shut down.
This can cause problems if the worker shut down hangs as observed in #245, because the EH client does not shut down, causing issues.
This PR modifies the shut down so that clients & connections are shut down in parallel with the workers. This fixes the problem described above, and also improves the speed of the shutdown process.