Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Az Func dotnet-isolated extension #216

Merged
merged 1 commit into from
Jan 19, 2023
Merged

Fix Az Func dotnet-isolated extension #216

merged 1 commit into from
Jan 19, 2023

Conversation

jviau
Copy link
Member

@jviau jviau commented Jan 19, 2023

Two fixes:

  1. Make sure assembly name and package name match (for consistency)
  2. Add enableImplicitRegistration = true to the extension attribute.
    • This is because our package has 0 binding attributes in it, the build task skips it unless this is set to true.

@jviau jviau merged commit 2edfb61 into microsoft:main Jan 19, 2023
@jviau jviau deleted the fix-extension branch January 19, 2023 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastianburckhardt sebastianburckhardt sebastianburckhardt approved these changes

@cgillum cgillum Awaiting requested review from cgillum

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jviau @sebastianburckhardt