Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Functions isolated extension package #212

Merged
merged 4 commits into from
Jan 13, 2023
Merged

Conversation

jviau
Copy link
Member

@jviau jviau commented Jan 5, 2023

This PR enables netherite usage in Azure functions dotnet isolated.

  • Adds a new project and nuget package Microsoft.Azure.Functions.Worker.Extensions.DurableTask.Netherite, which has a single attribute that tells the host to load the Microsoft.Azure.DurableTask.Netherite.AzureFunctions package.
    • Customers will reference this package in their dotnet isolated projects (and not Microsoft.Azure.DurableTask.Netherite.AzureFunctions)
  • Adds dirs.proj for release build, updates azure-pipelines-release.yml to use this.

Copy link
Member

@davidmrdavid davidmrdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good to me, though I noticed the CI is failing due to the env variables not being read. Is that something you're looking into?

</ItemGroup>

<ItemGroup>
<PackageReference Include="Microsoft.Azure.Functions.Worker.Extensions.Abstractions" Version="1.1.0" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add a comment here to update the AssemblyInfo whenever we update this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the version that is to be kept in sync. It is the version of Microsoft.Azure.DurableTask.Netherite.AzureFunctions. Ultimately, it would be nice to automate this - but that can be left for a separate PR as we would need to extract some common versioning targets between the two projects.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, my mistake. I misread this (twice, one per PR). Thanks, this makes sense.

@jviau
Copy link
Member Author

jviau commented Jan 6, 2023

I have not looked too much into the CI failure, as I saw what you saw: a config issue, and I did not touch that project. So unsure what is going on. @sebastianburckhardt do you have context?

Copy link
Member

@sebastianburckhardt sebastianburckhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The issue with the CI should resolve on its own once we merge this.

@jviau jviau merged commit b675ec3 into microsoft:main Jan 13, 2023
@jviau jviau deleted the func-isolated branch January 13, 2023 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants