-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Functions isolated extension package #212
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks good to me, though I noticed the CI is failing due to the env variables not being read. Is that something you're looking into?
</ItemGroup> | ||
|
||
<ItemGroup> | ||
<PackageReference Include="Microsoft.Azure.Functions.Worker.Extensions.Abstractions" Version="1.1.0" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we add a comment here to update the AssemblyInfo whenever we update this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not the version that is to be kept in sync. It is the version of Microsoft.Azure.DurableTask.Netherite.AzureFunctions
. Ultimately, it would be nice to automate this - but that can be left for a separate PR as we would need to extract some common versioning targets between the two projects.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, my mistake. I misread this (twice, one per PR). Thanks, this makes sense.
I have not looked too much into the CI failure, as I saw what you saw: a config issue, and I did not touch that project. So unsure what is going on. @sebastianburckhardt do you have context? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. The issue with the CI should resolve on its own once we merge this.
This PR enables netherite usage in Azure functions dotnet isolated.
Microsoft.Azure.Functions.Worker.Extensions.DurableTask.Netherite
, which has a single attribute that tells the host to load theMicrosoft.Azure.DurableTask.Netherite.AzureFunctions
package.Microsoft.Azure.DurableTask.Netherite.AzureFunctions
)dirs.proj
for release build, updatesazure-pipelines-release.yml
to use this.