fix ActivitySchedulerOptions (#138)

microsoft · Apr 14, 2022 · 5d18cb1 · 5d18cb1
1 parent b050e46
commit 5d18cb1
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 18 deletions.
diff --git a/src/DurableTask.Netherite/OrchestrationService/ActivitySchedulerOptions.cs b/src/DurableTask.Netherite/OrchestrationService/ActivitySchedulerOptions.cs
@@ -30,20 +30,6 @@ public enum ActivitySchedulerOptions
 
     public static class ActivityScheduling
     {
-        public static bool RequiresLoadMonitor(ActivitySchedulerOptions options)
-        {
-            switch (options)
-            {
-                case ActivitySchedulerOptions.Local:
-                case ActivitySchedulerOptions.Static:
-                    return false;
-                case ActivitySchedulerOptions.Locavore:
-                    return true;
-                default:
-                    throw new NotImplementedException("missing switch case");
-            }
-        }
-
         public static bool RequiresPeriodicOffloadDecision(ActivitySchedulerOptions options)
         {
             switch (options)
@@ -56,8 +42,6 @@ public static bool RequiresPeriodicOffloadDecision(ActivitySchedulerOptions opti
                 default:
                     throw new NotImplementedException("missing switch case");
             }
-        }
-
-
+        }   
     }
 }
diff --git a/src/DurableTask.Netherite/StorageProviders/Faster/StoreWorker.cs b/src/DurableTask.Netherite/StorageProviders/Faster/StoreWorker.cs
@@ -446,7 +446,7 @@ protected override async Task Process(IList<PartitionEvent> batch)
                     await this.PublishLoadAndPositions();
                 }
 
-                if (this.partition.NumberPartitions() > 1)
+                if (this.partition.NumberPartitions() > 1 && this.partition.Settings.ActivityScheduler == ActivitySchedulerOptions.Locavore)
                 {
                     var activitiesState = (await this.store.ReadAsync(TrackedObjectKey.Activities, this.effectTracker)) as ActivitiesState;
                     activitiesState.CollectLoadMonitorInformation();