fix race condition on OrchestrationRuntimeState.NewEvents (#380)

* fix race condition on mutable list of new events inside OrchestrationRuntimeState. * Apply suggestions from code review Co-authored-by: David Justo <[email protected]> --------- Co-authored-by: David Justo <[email protected]>
microsoft · Apr 15, 2024 · 2f94e76 · 2f94e76
1 parent b885bd4
commit 2f94e76
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/DurableTask.Netherite/OrchestrationService/NetheriteOrchestrationService.cs b/src/DurableTask.Netherite/OrchestrationService/NetheriteOrchestrationService.cs
@@ -876,7 +876,7 @@ Task IOrchestrationService.CompleteTaskOrchestrationWorkItemAsync(
                 InstanceId = workItem.InstanceId,
                 BatchStartPosition = messageBatch.BatchStartPosition,
                 BatchLength = messageBatch.BatchLength,
-                NewEvents = (List<HistoryEvent>)newOrchestrationRuntimeState.NewEvents,
+                NewEvents = newOrchestrationRuntimeState.NewEvents.ToList(), // `NewEvents` in `newOrchestrationRuntimeState` may be mutated, so we copy to avoid a surprise change.
                 WorkItemForReuse = cacheWorkItemForReuse ? orchestrationWorkItem : null,
                 PackPartitionTaskMessages = partition.Settings.PackPartitionTaskMessages,
                 PersistFirst = partition.Settings.PersistStepsFirst ? BatchProcessed.PersistFirstStatus.Required : BatchProcessed.PersistFirstStatus.NotRequired,