This repository has been archived by the owner on Nov 16, 2023. It is now read-only.
Allow dtslint types @bla/foo
#47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently when running `npm run lint @bla/foo` in https://github.com/DefinitelyTyped/DefinitelyTyped it errors with: ``` ➜ DefinitelyTyped git:(add-@storybook__react) ✗ npm run lint @storybook/react > [email protected] lint /Users/joscha/Development/DefinitelyTyped > dtslint types "@storybook/react" ENOENT: no such file or directory, open '/Users/joscha/Development/DefinitelyTyped/types/@storybook/react/index.d.ts' npm ERR! Darwin 16.6.0 npm ERR! argv "/usr/local/bin/node" "/usr/local/bin/npm" "run" "lint" "@storybook/react" npm ERR! node v7.5.0 npm ERR! npm v4.2.0 npm ERR! code ELIFECYCLE npm ERR! errno 1 npm ERR! [email protected] lint: `dtslint types "@storybook/react"` npm ERR! Exit status 1 ``` for scoped packages. references microsoft/dts-gen#63
|
This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request. |
|
references DefinitelyTyped/DefinitelyTyped#16970 |
This was referenced Jun 5, 2017
|
Thanks! |
ghost
merged commit 
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when running
npm run lint @bla/fooin https://github.com/DefinitelyTyped/DefinitelyTyped it errors with:for scoped packages.
references microsoft/dts-gen#63, DefinitelyTyped/dt-review-tool#11
Workaround is currently to run
npm run lint storybook__react