Fix MAR search links with trailing slash #1175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mthalman
approved these changes
Oct 1, 2024
There was a problem hiding this comment.
This is fine as a temporary measure.
I've filed an issue for MAR because this should get fixed: microsoft/containerregistry#171. We really do want the dotnet/ query to work properly to avoid getting hits on other teams' .NET-related repos but not within the scope of the dotnet/ repo.
Thanks, I threw that issue in the tracking column of the .NET Docker board. |
|
I fixed other broken links that were upsetting the link checker - the same as dotnet/dotnet-docker@3562f21 |
|
Build failure is #1117, merging around that since it's unrelated to changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MAR link https://mcr.microsoft.com/catalog?search=dotnet/framework/ results in a page that says "Sorry, we encountered an error. Please try again later". Removing the trailing slash fixes it, so I've adjusted the templates accordingly.