Fix Build Warnings for Newer .NET SDK

Directory.Build.props

@@ -55,7 +55,9 @@
   <Choose>
     <When Condition="$(MSBuildProjectName)!='Microsoft.Health.Extensions.BuildTimeCodeGenerator' AND !$(MSBuildProjectName.Contains('Test'))">
       <PropertyGroup>
+        <AnalysisLevel>5.0</AnalysisLevel>
         <AnalysisMode>AllEnabledByDefault</AnalysisMode>
+        <EnforceCodeStyleInBuild>true</EnforceCodeStyleInBuild>
       </PropertyGroup>
     </When>
   </Choose>

build/docker/Dockerfile

@@ -1,5 +1,5 @@
 # Start from the sdk image
-FROM mcr.microsoft.com/dotnet/sdk:5.0.103-alpine3.12@sha256:3e31dfc4639dfc80fe38f40496eff7541f574edd1248b53eca7334f884cd5d4d AS build
+FROM mcr.microsoft.com/dotnet/sdk:5.0.201-alpine3.12@sha256:b868e7c133fa9089a031ecc2766d5524c9a1a9a76602ef07d2e3ab4c7e0a5130 AS build
 
 # Set the working directory to where the source is located
 WORKDIR /src
@@ -12,7 +12,7 @@ RUN dotnet build --configuration Release
 RUN dotnet publish "./src/Microsoft.Health.Dicom.Web/Microsoft.Health.Dicom.Web.csproj" -c Release -o "/build" --no-build
 
 # Build the runtime image
-FROM mcr.microsoft.com/dotnet/aspnet:5.0.3-alpine3.12@sha256:5de46fc04b1dc08994ea810d427536cbb2491604768cf665d2001634181937ab AS runtime
+FROM mcr.microsoft.com/dotnet/aspnet:5.0.4-alpine3.12@sha256:edf03b07bd084a8c98115416021bc1413ed3338ffb532800e8ea83286bb283bd AS runtime
 
 RUN set -x && \
     # See https://www.abhith.net/blog/docker-sql-error-on-aspnet-core-alpine/

converter/dicom-cast/build/docker/Dockerfile

@@ -1,5 +1,5 @@
 # Start from the sdk image
-FROM mcr.microsoft.com/dotnet/sdk:5.0.103-alpine3.12@sha256:3e31dfc4639dfc80fe38f40496eff7541f574edd1248b53eca7334f884cd5d4d AS build
+FROM mcr.microsoft.com/dotnet/sdk:5.0.201-alpine3.12@sha256:b868e7c133fa9089a031ecc2766d5524c9a1a9a76602ef07d2e3ab4c7e0a5130 AS build
 
 # Set the working directory to where the source is located
 WORKDIR /dicom-cast/src
@@ -12,7 +12,7 @@ RUN dotnet build "./converter/dicom-cast/src/Microsoft.Health.DicomCast.Hosting/
 RUN dotnet publish "./converter/dicom-cast/src/Microsoft.Health.DicomCast.Hosting/Microsoft.Health.DicomCast.Hosting.csproj" -c Release -o "/.build" --no-build
 
 # Build the runtime image
-FROM mcr.microsoft.com/dotnet/aspnet:5.0.3-alpine3.12@sha256:5de46fc04b1dc08994ea810d427536cbb2491604768cf665d2001634181937ab AS runtime
+FROM mcr.microsoft.com/dotnet/aspnet:5.0.4-alpine3.12@sha256:edf03b07bd084a8c98115416021bc1413ed3338ffb532800e8ea83286bb283bd AS runtime
 
 RUN set -x && \
     addgroup nonroot && \

global.json

@@ -1,5 +1,5 @@
 {
   "sdk": {
-    "version": "5.0.103"
+    "version": "5.0.201"
   }
 }

samples/templates/default-azuredeploy.json

@@ -239,7 +239,7 @@
                         "[variables('appServiceResourceId')]"
                     ],
                     "properties": {
-                        "version": "5.0.3"
+                        "version": "5.0.4"
                     }
                 },
                 {

src/Microsoft.Health.Dicom.Blob/Features/Storage/BlobFileStore.cs

@@ -28,7 +28,7 @@ namespace Microsoft.Health.Dicom.Blob.Features.Storage
     /// </summary>
     public class BlobFileStore : IFileStore
     {
-        private static readonly string GetFileStreamTagName = $"{nameof(BlobFileStore)}.{nameof(GetFileAsync)}";
+        private const string GetFileStreamTagName = nameof(BlobFileStore) + "." + nameof(GetFileAsync);
         private readonly BlobContainerClient _container;
         private readonly RecyclableMemoryStreamManager _recyclableMemoryStreamManager;
         private readonly BlobDataStoreConfiguration _blobDataStoreConfiguration;

src/Microsoft.Health.Dicom.Blob/Registration/DicomServerBuilderBlobRegistrationExtensions.cs

@@ -20,7 +20,7 @@ namespace Microsoft.Extensions.DependencyInjection
 {
     public static class DicomServerBuilderBlobRegistrationExtensions
     {
-        private static readonly string DicomServerBlobConfigurationSectionName = $"DicomWeb:DicomStore";
+        private const string DicomServerBlobConfigurationSectionName = "DicomWeb:DicomStore";
 
         /// <summary>
         /// Adds the blob data store for the DICOM server.

src/Microsoft.Health.Dicom.Metadata/Features/Storage/BlobMetadataStore.cs

@@ -31,8 +31,8 @@ namespace Microsoft.Health.Dicom.Metadata.Features.Storage
     /// </summary>
     public class BlobMetadataStore : IMetadataStore
     {
-        private static readonly string GetInstanceMetadataStreamTagName = $"{nameof(BlobMetadataStore)}.{nameof(GetInstanceMetadataAsync)}";
-        private static readonly string StoreInstanceMetadataStreamTagName = $"{nameof(BlobMetadataStore)}.{nameof(StoreInstanceMetadataAsync)}";
+        private const string GetInstanceMetadataStreamTagName = nameof(BlobMetadataStore) + "." + nameof(GetInstanceMetadataAsync);
+        private const string StoreInstanceMetadataStreamTagName = nameof(BlobMetadataStore) + "." + nameof(StoreInstanceMetadataAsync);
         private static readonly Encoding _metadataEncoding = Encoding.UTF8;
 
         private readonly BlobContainerClient _container;

src/Microsoft.Health.Dicom.Metadata/Registration/DicomServerBuilderMetadataRegistrationExtensions.cs

@@ -20,7 +20,7 @@ namespace Microsoft.Extensions.DependencyInjection
 {
     public static class DicomServerBuilderMetadataRegistrationExtensions
     {
-        private static readonly string DicomServerBlobConfigurationSectionName = $"DicomWeb:MetadataStore";
+        private const string DicomServerBlobConfigurationSectionName = "DicomWeb:MetadataStore";
 
         /// <summary>
         /// Adds the metadata store for the DICOM server.

tools/scale-testing/templates/default-azuredeploy.json

@@ -135,7 +135,7 @@
                         "[variables('appServiceResourceId')]"
                     ],
                     "properties": {
-                        "version": "5.0.3"
+                        "version": "5.0.4"
                     }
                 }
             ]