addRepo improvements #2298
Merged
addRepo improvements #2298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Kristen Schau <[email protected]>
Co-authored-by: Kristen Schau <[email protected]>
Co-authored-by: Kristen Schau <[email protected]>
…tps://github.com/microsoft/devhome into user/dhoehna/ImproveSearchingSortingAndFiltering
dhoehna
requested review from
krschau,
EricJohnson327,
bbonaby,
manodasanW,
jsidewhite,
huzaifa-d,
vineeththomasalex,
dkbennett,
SohamDas2021,
AmelBawa-msft and
a team
krschau
approved these changes
Feb 22, 2024
tools/SetupFlow/DevHome.SetupFlow/ViewModels/AddRepoViewModel.cs
Outdated
Show resolved
Hide resolved
tools/SetupFlow/DevHome.SetupFlow/ViewModels/AddRepoViewModel.cs
Outdated
Show resolved
Hide resolved
vineeththomasalex
approved these changes
Feb 28, 2024
dhoehna
added a commit
that referenced
this pull request
Mar 4, 2024
* USing tags * Can clone repos again. * Changing visibility to bool. * More changes * Account combobox is reset. * Adding some comments. * Combobox placeholder * Final touches * Fixing a comment. * Fixing SDk version * Ignoring a test * Update tools/SetupFlow/DevHome.SetupFlow/ViewModels/AddRepoViewModel.cs Co-authored-by: Kristen Schau <[email protected]> * Update tools/SetupFlow/DevHome.SetupFlow/ViewModels/AddRepoViewModel.cs Co-authored-by: Kristen Schau <[email protected]> * Update tools/SetupFlow/DevHome.SetupFlow/Views/AddRepoDialog.xaml Co-authored-by: Kristen Schau <[email protected]> * Changes * Removing prefixes for uid * Moving more things into the ViewModel. * Getting loginUI and provider name not null. * Ignoring anotehr test because making a new frame throws an exception. * Adding -async --------- Co-authored-by: Darren Hoehna <[email protected]> Co-authored-by: Kristen Schau <[email protected]>
dhoehna
added a commit
that referenced
this pull request
Mar 21, 2024
* Adding searching capability to the repo tool (#2245) * Re-adding lost changes * WIP * Minor tweaks * Cleaning up code. * Fixing code issues with new() * Reverting SDK version. * Reverting idl change because it is another PR. * Reverting package.appxmanifest change * Adding search term placeholder text * Removing a method. Using GetValuesFor * Removing a space * Moving QI to where it is used --------- Co-authored-by: Darren Hoehna <[email protected]> * Comment changes. (#2310) * Re-adding lost changes * WIP * Minor tweaks * Cleaning up code. * Fixing code issues with new() * Reverting SDK version. * Reverting idl change because it is another PR. * Reverting package.appxmanifest change * Adding search term placeholder text * Removing a method. Using GetValuesFor * Removing a space * Moving QI to where it is used * Comment changes --------- Co-authored-by: Darren Hoehna <[email protected]> * FIxing some errors. Making the UI closer to the mocks> (#2326) Co-authored-by: Darren Hoehna <[email protected]> * addRepo improvements (#2298) * USing tags * Can clone repos again. * Changing visibility to bool. * More changes * Account combobox is reset. * Adding some comments. * Combobox placeholder * Final touches * Fixing a comment. * Fixing SDk version * Ignoring a test * Update tools/SetupFlow/DevHome.SetupFlow/ViewModels/AddRepoViewModel.cs Co-authored-by: Kristen Schau <[email protected]> * Update tools/SetupFlow/DevHome.SetupFlow/ViewModels/AddRepoViewModel.cs Co-authored-by: Kristen Schau <[email protected]> * Update tools/SetupFlow/DevHome.SetupFlow/Views/AddRepoDialog.xaml Co-authored-by: Kristen Schau <[email protected]> * Changes * Removing prefixes for uid * Moving more things into the ViewModel. * Getting loginUI and provider name not null. * Ignoring anotehr test because making a new frame throws an exception. * Adding -async --------- Co-authored-by: Darren Hoehna <[email protected]> Co-authored-by: Kristen Schau <[email protected]> * Enabling Search inputs with IRepositoryProvider (#2244) * Adding IRepositoryProvider2 * Adding a space between the >'s * Modifying based on feedback. * Moving around arguments * Changes based on semi-API review * Adding implementation * HOlding onto the options * Copying a com array * Changing a name * Back to a working build. * WIP * eeeyyy, it works. Now need to add some smaller changes * Cleaning up code * Works and looks good * Adding comments * Fixing a typo * Adding locks. Getting search to work with one provider * Changing back to IIterable * Changing variable names * Adding a comment. * Adding another QI. Removing duplicate code. * Addressing comments. * Updating version * Removing plural --------- Co-authored-by: Darren Hoehna <[email protected]> * Updating version * Changing version --------- Co-authored-by: Darren Hoehna <[email protected]> Co-authored-by: Kristen Schau <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
These improvements are in #2286. That PR is frozen until design looks at it. A minimum of 2 weeks. Instead of waiting I moved the improvement code changes into this PR.
References and relevant issues
Detailed description of the pull request / Additional comments
I moved more code out of the View's code-behind and into
AddRepoViewModel.The code in
AddRepoViewModelis a bit messier and it still has a reference back toAddRepoDialogHowever, this is a necessary step to get as much code out ofAddRepoDialog.xaml.csas possible.Validation steps performed
Cloned repos and added a Dev Drive.
Signed into github after clicking an account.
PR checklist