Fix for boolean vector bug NA -> TRUE #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1123,7 +1123,8 @@ static SEXP decode_to_SEXP(unsigned int **buf, int *UPC) | |||
| (*UPC)++; | |||
| i = 0; | |||
| while (i < vl) { | |||
| LOGICAL(val)[i] = cb[i]; | |||
| // LOGICAL(val)[i] = cb[i]; | |||
| LOGICAL(val)[i] = (cb[i] == 1) ? TRUE : ((cb[i] == 0) ? FALSE : NA_LOGICAL); | |||
There was a problem hiding this comment.
what does that mean? when does cb[I] is 1 and what does it mean?
There was a problem hiding this comment.
When a REXPLogical vector is passed to Rserve using Buffer, TRUE = 1, FALSE = 0, NA = -124
cb is buffer which would contain the values passed from Rserve client
while parsing this buffer and creating a Logical vector for R, we check for correct values and assing them in in LOGICAL vector
This is the Fix I found in latest version of Rserve 1.7 and I have used the same logic for parsing the Logical vector
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a Boolean vector is passed into Rserve which can have NA
NA is converted to TRUE, this is because the during the parsing we directly assign the values from buffer into logical vector and any non zero values are assumed to be true.
Fix is to properly assign TRUE, FALSE and NA values to logical vector