Use code object instead of (co_firstlineno, co_name, co_filename) for caching frame info. Fixes #837 Fixes #844 #851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… caching frame info. Fixes microsoft#837 Fixes microsoft#844
|
Kudos, SonarCloud Quality Gate passed!
|
int19h
approved these changes
Feb 24, 2022
This was referenced Feb 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue where the cache key used in the debugger was caching based on the information which could be sometimes repeated when the user generated code objects (and thus the debugger would think it had a cache hit when it didn't in reality).
With this change, the cache key for the information is the code object itself.
I hadn't done this previously because of the possibility of creating code object leaks (because any code object seen by the debugger will be kept alive forever), but after reviewing the code a bit it seems we already store those code-objects as cache keys in other places anyways (given that code objects are immutable it's hard to find a good place to store such info) so I gave in and just started to use the code object as the cache key as we "leak" those anyways already.