Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub links to each web package #11

Merged
merged 2 commits into from
Apr 19, 2019
Merged

Add GitHub links to each web package #11

merged 2 commits into from
Apr 19, 2019

Conversation

barryt2
Copy link
Contributor

@barryt2 barryt2 commented Apr 18, 2019

Add GitHub links to each web packages and remove "NPM Package" term from the title of the package's readme.

@barryt2 barryt2 requested a review from carlbrochu April 18, 2019 02:20
@dineshc-msft
Copy link
Contributor

I see version bump from 1.1.0 to 1.1.1. Is that needed?

@barryt2
Copy link
Contributor Author

barryt2 commented Apr 18, 2019

I see version bump from 1.1.0 to 1.1.1. Is that needed?

Yes because we have to publish our packages in order for the read me updates to show up in NPM. And in order to publish, versions need to be unique (i.e. you cannot publish over existing versions).

@barryt2 barryt2 changed the title Add GitHub links to each web package fixes #15 Add GitHub links to each web package Apr 19, 2019
@barryt2 barryt2 changed the title fixes #15 Add GitHub links to each web package fixes # 15 Add GitHub links to each web package Apr 19, 2019
@barryt2 barryt2 changed the title fixes # 15 Add GitHub links to each web package Add GitHub links to each web package Apr 19, 2019
@barryt2
Copy link
Contributor Author

barryt2 commented Apr 19, 2019

Fixes issue #15

@barryt2 barryt2 merged commit a94b736 into master Apr 19, 2019
@barryt2 barryt2 deleted the addgitlinks branch April 24, 2019 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants