Fix unit test compilation in CI #968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lalitb
requested review from
bliptec,
kindbe,
larvacea,
maxgolov,
mkoscumb,
reyang and
sid-dahiya
as code owners
sid-dahiya
approved these changes
Nov 30, 2021
reyang
approved these changes
Nov 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit test compilation is failing with error
/home/runner/work/cpp_client_telemetry/cpp_client_telemetry/tests/unittests/InformationProviderImplTests.cpp:30:9: error: ‘GetCallbacks’ function uses ‘auto’ type specifier without trailing return type 30 | const auto& GetCallbacks() { return callbacks; } | ^~~~~ /home/runner/work/cpp_client_telemetry/cpp_client_telemetry/tests/unittests/InformationProviderImplTests.cpp:30:9: note: deduced return type only available with ‘-std=c++14’ or ‘-std=gnu++14’ make[2]: *** [tests/unittests/CMakeFiles/UnitTests.dir/build.make:398: tests/unittests/CMakeFiles/UnitTests.dir/InformationProviderImplTests.cpp.o] Error 1 make[1]: *** [CMakeFiles/Makefile2:219: tests/unittests/CMakeFiles/UnitTests.dir/all] Error 21DS SDK should compile successfully with compilers with C++11 support, while the auto return type "without trailing return type" used in the unit-test is a C++14 feature.
Looks like the error surfaced out after some recent changes in the github environments.