Add device class field for iOS #945
Conversation
Qusic
requested review from
bliptec,
kindbe,
lalitb,
larvacea,
maxgolov,
mkoscumb,
reyang and
sid-dahiya
as code owners
There was a problem hiding this comment.
Change looks good, but would recommend getting a sign-off from @eduardo-camacho as well as he's the resident iOS/Obj-C expert.
| @@ -68,3 +68,19 @@ | |||
| return std::string { [[[UIDevice currentDevice] systemVersion] UTF8String] }; | |||
| } | |||
|
|
|||
| std::string GetDeviceClass() { | |||
| #if TARGET_IPHONE_SIMULATOR | |||
| return "iOS.Emulator"; | |||
There was a problem hiding this comment.
Usually Apple refers to this as "Simulator", not Emulator. Please change
| #else | ||
| switch (UIDevice.currentDevice.userInterfaceIdiom) { | ||
| case UIUserInterfaceIdiomPhone: | ||
| return "iOS.Phone"; |
There was a problem hiding this comment.
Please remove "iOS." prefix, it's not actually needed since tablets, phones, TV and car are iOS only.
| @@ -83,3 +83,6 @@ | |||
| return GetDeviceOsVersion(); | |||
| } | |||
|
|
|||
| std::string GetDeviceClass() { | |||
| return {}; | |||
|
Hi @eduardo-camacho |
I don't agree with documented naming, but not much to do now if it was already defined that way before, let's not break backward compatibility. Approving. |
Co-authored-by: Bang Lee <[email protected]>
https://1dsdocs.azurewebsites.net/schema/PartA/device.html#deviceclass