Fix android CI build ( migrate to maven ) #942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lalitb
requested review from
bliptec,
kindbe,
larvacea,
maxgolov,
mkoscumb,
reyang and
sid-dahiya
as code owners
reyang
approved these changes
Oct 14, 2021
|
Looks like CodeScan is failing for SQL Injection (a different issue from this PR). Will check, and if required add a fix for that too in this PR. |
|
Merging this PR as the android build is now successful. Will check CodeQL separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As jcenter is no more accessible from github CI actions ( refer: https://blog.gradle.org/jcenter-shutdown ), this PR migrates the repository to download Gradle build dependencies from jcenter to maven.