Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken codeql job. #1243

Merged
merged 5 commits into from
Feb 8, 2024
Merged

Fix broken codeql job. #1243

merged 5 commits into from
Feb 8, 2024

Conversation

utoni
Copy link
Contributor

@utoni utoni commented Feb 2, 2024

@utoni utoni requested a review from a team as a code owner February 2, 2024 12:18
Copy link
Contributor

@mkoscumb mkoscumb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@utoni
Copy link
Contributor Author

utoni commented Feb 3, 2024

There might be something wrong with the CLA check.

@lalitb lalitb merged commit f147079 into microsoft:main Feb 8, 2024
20 checks passed
@ThomsonTan
Copy link
Contributor

There are still CodeQL issue, is it the same one?

https://github.com/microsoft/cpp_client_telemetry/actions/runs/7826344379/job/21352028179

@utoni
Copy link
Contributor Author

utoni commented Feb 16, 2024

It seems that there was another issue, which was fixed with 5068a98.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants