Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding sample app changes for the swift wrappers #1175

Merged
merged 1 commit into from
Jun 23, 2023
Merged

adding sample app changes for the swift wrappers #1175

merged 1 commit into from
Jun 23, 2023

Conversation

absaroj
Copy link
Contributor

@absaroj absaroj commented Jun 21, 2023

No description provided.

mannie
mannie approved these changes Jun 22, 2023
View reviewed changes
Copy link
Member

@mannie mannie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For confirmation, this sample project is going to be moved to a different path later, right?

@absaroj
Copy link
Contributor Author

absaroj commented Jun 23, 2023 •
edited
Loading

For confirmation, this sample project is going to be moved to a different path later, right?

No. This is standalone swift file example to showcase the swift wrappers package usage.
I am creating another example xcodeproject which will import swift package and use the wrappers in "examples" folder.

@absaroj absaroj merged commit 42dae87 into main Jun 23, 2023
@absaroj absaroj deleted the absaroj/main_app_changes branch June 23, 2023 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eduardo-camacho eduardo-camacho eduardo-camacho approved these changes

@lalitb lalitb lalitb approved these changes

@mannie mannie mannie approved these changes

@kindbe kindbe Awaiting requested review from kindbe

@maxgolov maxgolov Awaiting requested review from maxgolov

@mkoscumb mkoscumb Awaiting requested review from mkoscumb

@reyang reyang Awaiting requested review from reyang

@bliptec bliptec Awaiting requested review from bliptec

@sid-dahiya sid-dahiya Awaiting requested review from sid-dahiya

@ThomsonTan ThomsonTan Awaiting requested review from ThomsonTan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@absaroj @mannie @lalitb @eduardo-camacho