Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass CXX_FLAGS from properties to maesdk module #1137

Merged
merged 2 commits into from
Apr 25, 2023

Conversation

TedaLIEz
Copy link
Contributor

Just like what we've discussed in #1136, passing parameter to build is more explicit.

We can get the CXX_FLAGS from the following:

  1. Add CXX_FLAGS in gradle.properties
  2. Pass param as -PCXX_FLAGS="xxxx" in command line, for example: ./gradlew :maesdk:assemble -PCXX_FLAGS="HAVE_CS4=1"
  3. Read the CXXFLAGS env variable (This is the fallback option)

@TedaLIEz
Copy link
Contributor Author

[Build for Android](https://github.com/microsoft/cpp_client_telemetry/actions/runs/4783012741/jobs/8502855774#step:2:491)
repository 'https://github.com/microsoft/cpp_client_telemetry_modules.git/' not found

Looks like a permission issue? I don't have the access to https://github.com/microsoft/cpp_client_telemetry_modules.git

@TedaLIEz
Copy link
Contributor Author

@anod Could you please help review this PR? And what should I do about the error in CI pipeline?

@anod
Copy link
Member

anod commented Apr 25, 2023

@anod Could you please help review this PR? And what should I do about the error in CI pipeline?

Looks like network issue, I rerun the build

> Could not resolve all files for configuration ':app:lintClassPath'.
   > Could not download groovy-all-2.4.15.jar (org.codehaus.groovy:groovy-all:2.4.15)
      > Could not get resource 'https://repo.maven.apache.org/maven2/org/codehaus/groovy/groovy-all/2.4.15/groovy-all-2.4.15.jar'.
         > Could not GET 'https://repo.maven.apache.org/maven2/org/codehaus/groovy/groovy-all/2.4.15/groovy-all-2.4.15.jar'.
            > Connection reset

@anod
Copy link
Member

anod commented Apr 25, 2023

[Build for Android](https://github.com/microsoft/cpp_client_telemetry/actions/runs/4783012741/jobs/8502855774#step:2:491)
repository 'https://github.com/microsoft/cpp_client_telemetry_modules.git/' not found

Looks like a permission issue? I don't have the access to https://github.com/microsoft/cpp_client_telemetry_modules.git

This is private repo which contain private / proprietary code not for OSS

Copy link
Contributor

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Good to merge once CI tests are successful

@TedaLIEz
Copy link
Contributor Author

@lalitb Could you please help merge the PR? It seems that I don't have the write access to this repo.

@lalitb lalitb merged commit 2aade07 into microsoft:main Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants