Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setTicketToken exposed to jni and java layer for Android apps to set tokens like AAD #1131

Merged
merged 5 commits into from
May 3, 2023

Conversation

sonalpoddarmsft
Copy link
Contributor

@sonalpoddarmsft sonalpoddarmsft commented Apr 14, 2023

Issue: #1128

@sonalpoddarmsft sonalpoddarmsft changed the title Expose the setTicketToken to jni and java layer for Android apps to s… setTicketToken exposed to jni and java layer for Android apps to set tokens like AAD Apr 14, 2023
@@ -585,6 +585,14 @@ namespace MAT_NS_BEGIN
static IAuthTokensController* GetAuthTokensController()
LM_SAFE_CALL_PTR(GetAuthTokensController);

///Sets the ticket token with a value
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put the comment into <summary></summary> node.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@sonalpoddarmsft sonalpoddarmsft marked this pull request as ready for review May 1, 2023 23:54
Copy link
Contributor

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The CI failure seems to be transient error due to network timeout, running again should fix it.

@sonalpoddarmsft sonalpoddarmsft merged commit 5a511c3 into main May 3, 2023
@sonalpoddarmsft sonalpoddarmsft deleted the sonalpoddar/ExposeSetTicketTokenToJavaForApps branch May 3, 2023 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants