-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ios simulator arm64 and arm64e support #1086
Conversation
…n with Apple Silicon (ARM) architecture
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me. But it is important to get the approval from @eduardo-camacho before merging it. As mentioned in the mail discussion:
Please make sure to have tested following scenarios (actually linking library and makes sure it works; lipo checking might not be enough):
- Simulator on M1
- Simulator on Intel
- Physical device on M1
- Physical device on Intel
Do you have an update on testing scenarios above? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a nit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have few comments.
I have tested with and without optional deployment target paramter by linking library on Simulator and Physical device with both M1 and Intel |
Resolved |
I have tested with and without optional deployment target paramter by linking library on Simulator and Physical device with both M1 and Intel. |
@swasti29 - Changes look good now. You should be able to merge this PR once CI checks are completed ( you may have to rerun the CI check incase of transient failures ). |
I approved yesterday night, we are good to go. Thanks! |
Update cmake to consider platform passed as argument for building 1DS for ios simulator m1(arm64 and arm64e) architecture