Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update krabsetw commit #1003

Merged
merged 3 commits into from
Mar 20, 2022
Merged

Update krabsetw commit #1003

merged 3 commits into from
Mar 20, 2022

Conversation

sid-dahiya
Copy link
Contributor

There are vulnerabilities in the nuget packages from krabsetw submodule. This change is moving the commit forward to try and fix the issue.

The error we are seeing in our pipeline:

Starting Multifeed Nuget Security Analysis: 
third_party/cpp_client_telemetry/third_party/krabsetw/Microsoft.O365.Security.Native.ETW/.nuget/NuGet.Config - Missing <clear/> statement.
third_party/cpp_client_telemetry/third_party/krabsetw/krabs/.nuget/NuGet.Config - Missing <clear/> statement.
Starting Multifeed Python Security Analysis: 
Starting CFS NuGet Analysis: 
third_party/cpp_client_telemetry/third_party/krabsetw/Microsoft.O365.Security.Native.ETW/.nuget/NuGet.Config - External feeds found in the file.
third_party/cpp_client_telemetry/third_party/krabsetw/krabs/.nuget/NuGet.Config - External feeds found in the file.
Starting CFS NPM Analysis: 
Azure Artifacts Configuration Analysis found 2 vulnerable NuGet package manifests in the repository. Visit http://aka.ms/azure-artifacts-configuration-analysis for more details.

@maxgolov
Copy link
Contributor

maxgolov commented Mar 18, 2022

Just a bit of history: I added this originally for some ETW work / test cases. Ideally I would recommend you to maybe get rid of that submodule entirely in the long run.... OpenTelemetry ETW exporter didn't need that code. And to test the receiving end of ETW events, e.g. for Unit Tests, etc. - it's easier to use C# receiver. I remember facing some limitations in KrabsETW, that ultimately C# receiver was better. Also for manual testing - Visual Studio 2019+ has a built-in ETW viewer right now.

This page covers some alternatives that do not require KrabsETW:
https://github.com/open-telemetry/opentelemetry-cpp/tree/main/exporters/etw

@sid-dahiya
Copy link
Contributor Author

Just a bit of history: I added this originally for some ETW work / test cases. Ideally I would recommend you to maybe get rid of that submodule entirely. OpenTelemetry ETW exporter didn't need that code. And to test the receiving end of ETW events, e.g. for Unit Tests, etc. - it's easier to use C# receiver. I remember facing some limitations in KrabsETW, that ultimately C# receiver was better. Also for manual testing - Visual Studio 2019+ has a built-in ETW viewer right now.

I think I might have to remove it. The module is introducing a .config file with its own dedicated nuget path and that's not supported in a lot of scenarios now.

@sid-dahiya sid-dahiya merged commit 80dcde4 into main Mar 20, 2022
@sid-dahiya sid-dahiya deleted the sid-dahiya/UpdateKrabsETWPackage branch March 20, 2022 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants